search

areve / IframeDashboardWidget

A dashboard widget to show an Iframe in TFS/VSTS.
10 stars 15 forks source link

if we are running http then allow http url #2

Closed GordonBeeming closed 8 years ago

GordonBeeming commented 8 years ago

This would fix #1 that I logged =D

areve commented 8 years ago

Thanks for your contribution I did wonder about this when I added the test. It'd be good to support http: too. Were you able to test that this code works? If you are using http://tfs is the iframe that hosts the widget configuration pane also on https?

I think it may be less risky to remove the http validation and just add a note to the bottom instead.

areve commented 8 years ago

I've updated the software to no longer do this validation. Thanks you for your contribution, please let me know how you get on.

GordonBeeming commented 8 years ago

Hi, I tested the change on http only using http. I also tested adding a https page and it worked.

I think if the site is running as https if we allow http the browser might see that as insecure.

Thanks again for the awesome extension =)