arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
216 stars 22 forks source link

Pi-hole FTL v5.13, Web v5.10 and Core v5.8 released #101

Closed town3r closed 2 years ago

ChrisWNY commented 2 years ago

Note that there were minor point releases since the original post - the versions are as follows:

Pi-hole v5.8.1 FTL v5.13 Web Interface v5.10.1

arevindh commented 2 years ago

@town3r @ChrisWNY will update tomorrow.

IDemixI commented 2 years ago

@arevindh - Just a heads up. In the latest version of the Web interface, the command pihole status web now returns a handful of different statuses. Before, I believe it was either 1, 0, -1 or "other". Now the standard output to display the pihole status as active is 53 (the port the DNS Service is running on). Code block below:

                    $pistatus = pihole_execute('status web');
                    if (isset($pistatus[0])) {
                        $pistatus = intval($pistatus[0]);
                    } else {
                        $pistatus = null;
                    }
                    if ($pistatus == 53) {
                        echo '<span id="status"><i class="fa fa-w fa-circle text-green-light"></i> Active</span>';
                    } elseif ($pistatus == 0) {
                        echo '<span id="status"><i class="fa fa-w fa-circle text-red"></i> Offline</span>';
                    } elseif ($pistatus == -1) {
                        echo '<span id="status"><i class="fa fa-w fa-circle text-red"></i> DNS service not running</span>';
                    } elseif ($pistatus == -2 || is_null($pistatus)) {
                        echo '<span id="status"><i class="fa fa-w fa-circle text-red"></i> Unknown</span>';
                    } else {
                        echo '<span id="status"><i class="fa fa-w fa-circle text-orange"></i> DNS service on port '.$pistatus.'</span>';
                    }
                    ?>

Good luck getting this update out :-) and thanks so much for the amazing pihole mod.

arevindh commented 2 years ago

@IDemixI @town3r @ChrisWNY something is wrong with pihole codebase, please don't update now.

ChrisWNY commented 2 years ago

What are the issues with the new Pi-hole code base? I've been running the current speedtest admin repo with Pi-hole core v5.8.1 and FTL 5.13 with no apparent issues.

arevindh commented 2 years ago

@ChrisWNY


  [i] Installing blocking page...
  [✓] Creating directory for blocking page, and copying files
  [i] Backing up index.lighttpd.html
      No default index.lighttpd.html file found... not backing up

  [✓] Installing sudoer file

  [✓] Installing latest Cron script

  [i] Installing latest logrotate script...
        [i] Existing logrotate file found. No changes made.
  [i] Backing up /etc/dnsmasq.conf to /etc/dnsmasq.conf.old
  [✓] man pages installed and database updated
  [i] Testing if systemd-resolved is enabled
  [i] Systemd-resolved does not need to be restarted
  [✓] Restarting lighttpd service...
  [✓] Enabling lighttpd service to start on reboot...
  [i] Restarting services...
  [✓] Enabling pihole-FTL service to start on reboot...
  [i] Restarting pihole-FTL service...
  Unable to complete update, please contact Pi-hole Support
arevindh commented 2 years ago

dnsmasq no longer starts.

arevindh commented 2 years ago

also #102

ChrisWNY commented 2 years ago

Ok I see the issue now...if you UPDATE to the latest Pi-hole admin repo, and just not use the speedtest repo, the pi-hole error goes away. I've taken a screenshot to show my instance...the speedtest admin repo is not currently installed but Pi-hole is working fine without it.

image

arevindh commented 2 years ago

The repo is updated, can you check now @ChrisWNY

town3r commented 2 years ago

Seems to be working again for myself!

ChrisWNY commented 2 years ago

Just downloaded the latest speedtest repo...no issues, seems to be working great!

IDemixI commented 2 years ago

Thanks, @arevindh. That's working perfectly again now!

Also, it's been confirmed that a new feature is bringing a lot of "hidden" DNSMASQ errors to the surface (aka now displaying them on the UI) - If you want to read more, see the post I put on the Pihole community - https://discourse.pi-hole.net/t/dnsmasq-warnings/52340

flipptx commented 2 years ago

so is it safe to update?

arevindh commented 2 years ago

so is it safe to update?

Yes