arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
218 stars 22 forks source link

Error on web interface due to installation #102

Closed xnetworker closed 2 years ago

xnetworker commented 2 years ago

The installation generates an error in the Pi-Hole web interface.

Bildschirmfoto 2022-01-07 um 11 54 49

It indicates an update. After executing pihole -up I get the message that everything is up to date. There is also no speed test carried out. Bildschirmfoto 2022-01-07 um 12 46 29

arevindh commented 2 years ago

@xnetworker The version still needs to be updated for this mod (Last updates are listed here ). Once the mod is updated you can follow this.update procedure.

arevindh commented 2 years ago

I have the same issue , will post once I find a solution, try restarting device too.

ChrisWNY commented 2 years ago

If you update to the latest pi-hole admin repo, this error message will go away and pi-hole will run just fine. You'll have to avoid installing/updating the speedtest admin repo until Sid updates it.

To get the OFFICIAL Pi-hole Admin repo, follow the REVERT steps:

Revert to pi-hole official pihole:

Revert admin sudo su

cd /var/www/html/

rm -rf admin

git clone https://github.com/pi-hole/AdminLTE admin

Revert pi-hole

cd /opt/pihole/

rm webpage.sh

wget https://github.com/pi-hole/pi-hole/raw/master/advanced/Scripts/webpage.sh

chmod +x webpage.sh

If you follow the MANUAL UPDATE instructions...

https://github.com/arevindh/pihole-speedtest/wiki/Updating--Speedtest-Mod

STOP after pihole -up has completed and you'll be fine. The pi-hole speedtest graph will not show up but all of the data will still be there and once you install the updated pi-hole speedtest admin repo things should be good to go.

image

xnetworker commented 2 years ago

Now, the automatic speed test is not working. When I start over the shell it runs.

The manual start provides the following errors Error: table speedtest has 11 columns but 13 values were supplied

arevindh commented 2 years ago

Now, the automatic speed test is not working. When I start over the shell it runs.

The manual start provides the following errors Error: table speedtest has 11 columns but 13 values were supplied

Can you try changing the period ?

xnetworker commented 2 years ago

Can you try changing the period ?

I don't understand

arevindh commented 2 years ago

Can you try changing the period ?

I don't understand Change this to something else and try. image

xnetworker commented 2 years ago

The same: pi@raspberrypi:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-11 06:53:14 2022-01-11 06:53:40 Deutsche Telekom AG xxx.xxx.xxxx.xxx IBH IT-Service GmbH 0 6.14 223,371 112,523 https://www.speedtest.net/result/c/890c4cf7-d461-4885-a579-a3574a3b6f7a Error: table speedtest has 11 columns but 13 values were supplied

arevindh commented 2 years ago

The same: pi@raspberrypi:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-11 06:53:14 2022-01-11 06:53:40 Deutsche Telekom AG xxx.xxx.xxxx.xxx IBH IT-Service GmbH 0 6.14 223,371 112,523 https://www.speedtest.net/result/c/890c4cf7-d461-4885-a579-a3574a3b6f7a Error: table speedtest has 11 columns but 13 values were supplied

Is it a new install or an old one ?

Make sure that official CLI is selected image

If nothing fixes the issue, select Flush Speedtest history and click save (Warning this will delete your speedtest history).

xnetworker commented 2 years ago

I have already carried out the recommendations several times. it's a fresh install

This is in the current database file: Bildschirmfoto 2022-01-11 um 17 08 55

arevindh commented 2 years ago

Can you post the output of

  1. tail -5 /var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh
  2. cd /var/www/html/admin/ && git rev-parse HEAD
xnetworker commented 2 years ago

Bildschirmfoto 2022-01-12 um 06 34 42

arevindh commented 2 years ago

Bildschirmfoto 2022-01-12 um 06 34 42

Seems there are additional quotes being added to the query.

arevindh commented 2 years ago

Bildschirmfoto 2022-01-12 um 06 34 42

Please post the output of /usr/bin/speedtest --accept-gdpr --accept-license -f json-pretty , remember to remove all personally identifiable information.

xnetworker commented 2 years ago

Bildschirmfoto 2022-01-13 um 06 26 18

xnetworker commented 2 years ago

Is there a solution yet?

arevindh commented 2 years ago

I wasn't able to re-create your issue from my side. As a last try can you try editing the last line of

/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh

from

sqlite3 /etc/pihole/speedtest.db "insert into speedtest values (NULL, '${start}', '${stop}', '${isp}', '${from_ip}', '${server_name}', ${server_dist}, ${server_ping}, ${download}, ${upload}, '${share_url}');"

to

echo "insert into speedtest values (NULL, '${start}', '${stop}', '${isp}', '${from_ip}', '${server_name}', ${server_dist}, ${server_ping}, ${download}, ${upload}, '${share_url}');"

Is there a solution yet?

xnetworker commented 2 years ago

pi@raspberrypi:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-17 17:07:06 2022-01-17 17:07:20 Deutsche Telekom AG xxx.xxx.xxx.xx IBH IT-Service GmbH 0 6.381 535,719 116,308 https://www.speedtest.net/result/c/0aa700e1-6151-4c64-9c35-fdf0f979a654 insert into speedtest values (NULL, '2022-01-17 17:07:06', '2022-01-17 17:07:20', 'Deutsche Telekom AG', 'xx.xxx.206.10', 'IBH IT-Service GmbH', 0, 6.381, 535,719, 116,308, 'https://www.speedtest.net/result/c/0aa700e1-6151-4c64-9c35-fdf0f979a654');

arevindh commented 2 years ago

pi@raspberrypi:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-17 17:07:06 2022-01-17 17:07:20 Deutsche Telekom AG xxx.xxx.xxx.xx IBH IT-Service GmbH 0 6.381 535,719 116,308 https://www.speedtest.net/result/c/0aa700e1-6151-4c64-9c35-fdf0f979a654 insert into speedtest values (NULL, '2022-01-17 17:07:06', '2022-01-17 17:07:20', 'Deutsche Telekom AG', 'xx.xxx.206.10', 'IBH IT-Service GmbH', 0, 6.381, 535,719, 116,308, 'https://www.speedtest.net/result/c/0aa700e1-6151-4c64-9c35-fdf0f979a654');

Seems like upload and download values doubled. Can you show me the speed-test config page too ? It might be a regional thing that uses , instead of .

arevindh commented 2 years ago

@xnetworker can you try this fix ?

https://github.com/arevindh/AdminLTE/pull/46/files

arevindh commented 2 years ago

@ChrisWNY @xnetworker Can you help me with your speed-test cli version ? /usr/bin/speedtest --version

xnetworker commented 2 years ago

pi@raspberrypi:~ $ /usr/bin/speedtest --version Speedtest by Ookla 1.0.0.2 (5ae238b) Linux/arm-linux-musleabihf 5.10.63-v7l+ arm/armv7l

xnetworker commented 2 years ago

pi@raspberrypi:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-18 07:08:22 2022-01-18 07:08:37 Deutsche Telekom AG xx.xxx.xxx.xx IBH IT-Service GmbH 0 6.702 203,191 112,345 https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d insert into speedtest values (NULL, '2022-01-18 07:08:22', '2022-01-18 07:08:37', 'Deutsche Telekom AG', 'xx.xxx.xx.1x', 'IBH IT-Service GmbH', 0, 6.702, 203,191, 112,345, 'https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d');

arevindh commented 2 years ago

pi@raspberrypi:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-18 07:08:22 2022-01-18 07:08:37 Deutsche Telekom AG xx.xxx.xxx.xx IBH IT-Service GmbH 0 6.702 203,191 112,345 https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d insert into speedtest values (NULL, '2022-01-18 07:08:22', '2022-01-18 07:08:37', 'Deutsche Telekom AG', 'xx.xxx.xx.1x', 'IBH IT-Service GmbH', 0, 6.702, 203,191, 112,345, 'https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d');

Can you add result of /usr/bin/speedtest --accept-gdpr --accept-license -f json-pretty --unit B/s

xnetworker commented 2 years ago

@.***:~ $ sudo /usr/bin/speedtest --accept-gdpr --accept-license -f json-pretty --unit B/s { "type": "result", "timestamp": "2022-01-18T10:11:38Z", "ping": { "jitter": 0.26300000000000001, "latency": 10.613 }, "download": { "bandwidth": 66788956, "bytes": 479884320, "elapsed": 7216 }, "upload": { "bandwidth": 13978877, "bytes": 139515470, "elapsed": 9904 }, "packetLoss": 0, "isp": "Deutsche Telekom AG", "interface": { "internalIp": „xxx.xxx.xx.x", "name": "eth0", "macAddr": „xx:xx:xx:xx:xx:xx", "isVpn": false, "externalIp": „00.000.000.00" }, "server": { "id": 41175, "name": "CITUX GmbH", "location": "Dresden", "country": "Germany", "host": "speedtest.citux.de", "port": 8080, "ip": "188.34.181.143" }, "result": { "id": "7fa1921c-3ad5-42d5-8af1-8f55ecc6fe72", "url": "https://www.speedtest.net/result/c/7fa1921c-3ad5-42d5-8af1-8f55ecc6fe72" } }

Am 18.01.2022 um 09:18 schrieb itsmesid @.***>:

@.***:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-18 07:08:22 2022-01-18 07:08:37 Deutsche Telekom AG xx.xxx.xxx.xx IBH IT-Service GmbH 0 6.702 203,191 112,345 https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d insert into speedtest values (NULL, '2022-01-18 07:08:22', '2022-01-18 07:08:37', 'Deutsche Telekom AG', 'xx.xxx.xx.1x', 'IBH IT-Service GmbH', 0, 6.702, 203,191, 112,345, 'https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d');

Can you add result of /usr/bin/speedtest --accept-gdpr --accept-license -f json-pretty --unit B/s

— Reply to this email directly, view it on GitHub https://github.com/arevindh/pihole-speedtest/issues/102#issuecomment-1015169044, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5AMLULKA6LO2XTRYAEGZTUWUO65ANCNFSM5LORAZBA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

arevindh commented 2 years ago

@.:~ $ sudo /usr/bin/speedtest --accept-gdpr --accept-license -f json-pretty --unit B/s { "type": "result", "timestamp": "2022-01-18T10:11:38Z", "ping": { "jitter": 0.26300000000000001, "latency": 10.613 }, "download": { "bandwidth": 66788956, "bytes": 479884320, "elapsed": 7216 }, "upload": { "bandwidth": 13978877, "bytes": 139515470, "elapsed": 9904 }, "packetLoss": 0, "isp": "Deutsche Telekom AG", "interface": { "internalIp": „xxx.xxx.xx.x", "name": "eth0", "macAddr": „xx:xx:xx:xx:xx:xx", "isVpn": false, "externalIp": „00.000.000.00" }, "server": { "id": 41175, "name": "CITUX GmbH", "location": "Dresden", "country": "Germany", "host": "speedtest.citux.de", "port": 8080, "ip": "188.34.181.143" }, "result": { "id": "7fa1921c-3ad5-42d5-8af1-8f55ecc6fe72", "url": "https://www.speedtest.net/result/c/7fa1921c-3ad5-42d5-8af1-8f55ecc6fe72" } } Am 18.01.2022 um 09:18 schrieb itsmesid @.>: @.***:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-18 07:08:22 2022-01-18 07:08:37 Deutsche Telekom AG xx.xxx.xxx.xx IBH IT-Service GmbH 0 6.702 203,191 112,345 https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d insert into speedtest values (NULL, '2022-01-18 07:08:22', '2022-01-18 07:08:37', 'Deutsche Telekom AG', 'xx.xxx.xx.1x', 'IBH IT-Service GmbH', 0, 6.702, 203,191, 112,345, 'https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d https://www.speedtest.net/result/c/d08c05b6-77f3-4d6a-9e62-57dbd153a23d'); Can you add result of /usr/bin/speedtest --accept-gdpr --accept-license -f json-pretty --unit B/s — Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5AMLULKA6LO2XTRYAEGZTUWUO65ANCNFSM5LORAZBA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

echo '139515470' | awk '{$1=$1*8/1000/1000; print $1;}'

Please add your timezone and locale information too.

It seems like , is used instead of .

xnetworker commented 2 years ago

The right time zone was set.

root@raspberrypi:/home/sudo dpkg-reconfigure tzdata

Current default time zone: 'Europe/Berlin' Local time is now: Tue Jan 18 14:32:32 CET 2022. Universal Time is now: Tue Jan 18 13:32:32 UTC 2022.

What should I do? Uninstall and reinstall it again?

arevindh commented 2 years ago

The right time zone was set.

root@raspberrypi:/home/sudo dpkg-reconfigure tzdata

Current default time zone: 'Europe/Berlin' Local time is now: Tue Jan 18 14:32:32 CET 2022. Universal Time is now: Tue Jan 18 13:32:32 UTC 2022.

What should I do? Uninstall and reinstall it again?

And the output of the above code line ?

xnetworker commented 2 years ago

root@raspberrypi:/home/pi# echo '139515470' | awk '{$1=$1*8/1000/1000; print $1;}' 1116,12

ChrisWNY commented 2 years ago

Sorry for the late reply -

speedtest --version Speedtest by Ookla 1.0.0.2 (5ae238b) Linux/arm-linux-musleabihf 5.10.90-v7l+ arm/armv7l

The official command line client for testing the speed and performance of your internet connection.

arevindh commented 2 years ago

root@raspberrypi:/home/pi# echo '139515470' | awk '{$1=$1*8/1000/1000; print $1;}' 1116,12

Yeah this is the problem, give me some time to figure out how to replicate it in my side . Then I can search for the fix .

arevindh commented 2 years ago

root@raspberrypi:/home/pi# echo '139515470' | awk '{$1=$1*8/1000/1000; print $1;}' 1116,12

Yeah this is the problem, give me some time to figure out how to replicate it in my side . Then I can search for the fix .

https://adrian.frith.dev/decimal-comma-ubuntu/

Please try this also

xnetworker commented 2 years ago

@.***:~ $ sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh" Testing with 2022-01-18 16:37:42 2022-01-18 16:38:04 Deutsche Telekom AG xx.xxx.xxx.xx Stadtwerke Finsterwalde 0 30.213 537,39 110,754 https://www.speedtest.net/result/c/4fbb10d3-4571-406e-a35d-ff2fcc4ebf05 insert into speedtest values (NULL, '2022-01-18 16:37:42', '2022-01-18 16:38:04', 'Deutsche Telekom AG', ’xx.xx.xx.xx', 'Stadtwerke Finsterwalde', 0, 30.213, 537,39, 110,754, 'https://www.speedtest.net/result/c/4fbb10d3-4571-406e-a35d-ff2fcc4ebf05‘);

Am 18.01.2022 um 16:04 schrieb itsmesid @.***>:

@.**:/home/pi# echo '139515470' | awk '{$1=$18/1000/1000; print $1;}' 1116,12

Yeah this is the problem, give me some time to figure out how to replicate it in my side . Then I can search for the fix .

sudo update-locale LC_NUMERIC="en_GB.UTF-8 try restarting after this

— Reply to this email directly, view it on GitHub https://github.com/arevindh/pihole-speedtest/issues/102#issuecomment-1015500795, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW5AMLUMAOPPBA2N2MSUFKTUWV6PVANCNFSM5LORAZBA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

xnetworker commented 2 years ago

Do you still work on an adjustment or do I have anything else?

arevindh commented 2 years ago

@xnetworker Was a bit busy with office work, will checkout it soon.