search

arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
218 stars 22 forks source link

Pi-hole FTL v5.14, Web v5.11 and Core v5.9 released #105

Closed town3r closed 2 years ago

town3r commented 2 years ago

https://pi-hole.net/blog/2022/02/12/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/

corasaniti commented 2 years ago

when you plan to upgrade to versions Pi-hole v5.9 FTL v5.14 Web Interface v5.11 Thanks in advance

ChrisWNY commented 2 years ago

Looks like the Web UI saw some substantial changes with the 5.11 web UI release. I have been running Pi-hole 5.9 and FTL 5.14 in conjunction with the speedtest admin repo (5.10.1) without any issues.

You can update your Pi-hole following the manual update instructions, and continue to run the older speedtest admin repo over the new core/FTL. The Core/FTL/Web UI are all independent components...you can run the full Pihole-up update process then overwrite the default Web UI with the speedtest admin repo.

corasaniti commented 2 years ago

Can I perform the pihole-up update even inside a container? If I then remove and delete the container do I lose the changes that have not persisted in the docker image? Don't plan on updating your docker image to the latest versions of pihole? Thanks

corasaniti commented 2 years ago

Since the latest versions of pihole the update has been blocked inside a docker container. So your image cannot be updated. Unfortunately I'm forced to stop using it if you don't update your beautiful docker container Cattura

ChrisWNY commented 2 years ago

I don't use Docker images for pihole. I always update manually, Raspberry OS.

corasaniti commented 2 years ago

so your Docker image dies with this version of PiHole? Ok I won't use it anymore I'm very sorry :-( A real shame because I liked it a lot. Thanks

Can you provide me the Dockerfile I would like to try to do a build

ChrisWNY commented 2 years ago

Docker images/builds would have to be maintained and updated as the software components themselves are updated. So if there's a new version of software available that's part of your docker image you'd have to also wait on the maintainer to update that image file.

arevindh commented 2 years ago

@town3r @ChrisWNY @corasaniti Will update tomorrow.

arevindh commented 2 years ago

@town3r @ChrisWNY Updated, please let me know after testing

arevindh commented 2 years ago

@corasaniti docker image also updated, please check and confirm

town3r commented 2 years ago

@town3r @ChrisWNY Updated, please let me know after testing

Thanks for the quick turn around.

Looks good so far!

Now if only the dashboard graph for Speedtest matched the others in the Star Trek LCARS theme (dark) theme. ;-) image

ChrisWNY commented 2 years ago

Just updated, looks good, no issues and the new 5.11 Pi-hole web UI features seem to all be working. Thanks!

arevindh commented 2 years ago

@corasaniti docker image has some issues, please don't update now. speedtest cli is unable to contact DNS server from inside the container.

arevindh commented 2 years ago

Star Trek LCARS theme (dark)

Let me try what I can do this weekend.

arevindh commented 2 years ago

@town3r can you close this and create that create as a separate issue, It is easier to track .

corasaniti commented 2 years ago

@arevindh Docker container works great. You have been very kind Thank you :-)

town3r commented 2 years ago

@town3r can you close this and create that create as a separate issue, It is easier to track .

done! https://github.com/arevindh/pihole-speedtest/issues/106