Closed Falconcrest closed 2 years ago
@Falconcrest try updating both, let me know if it fixes the issue. 5.11.1 is released due to a major change in speedtest mod codebase.
@arevindh Did I understand you correctly, I should update PADD and Speedtest mod again? But Pi-Hole and PADD were up to date when I installed the last version of speedtest mod!
@Falconcrest yes, please try it https://github.com/arevindh/pihole-speedtest/wiki/Updating--Speedtest-Mod
@arevindh Sorry, I made a mistake in my remarks.
My version of pi-hole before installing the speedport mod was: Pi-hole version is v5.9 (Latest: v5.9) AdminLTE version is v5.11 (Latest: v5.11) FTL version is v5.14 (Latest: v5.14) PADD is version v3.3.6.
The "problem" is not PADD, there you can only see which version pi-hole and PADD have.
The speedtest mod now changes the AdminLTE version of pi-hole from 5.11 to v5.11.1, see here: Pi-hole version is v5.9 (Latest: v5.9) AdminLTE version is v5.11.1 (Latest: v5.11) FTL version is v5.14 (Latest: v5.14)
That's not really a problem, but PADD evaluates this and notices that the AdminLTE is no longer v5.11, but v5.11.1. Therefore, PADD now shows me that the AdminLTE is no longer up-to-date and updates are available.
Pi-hole® v5.9, Web v5.11.1, FTL v5.14, PADD v3.6.6 [✓] Core [✓] FTL [i] Updates are available.
As already described at the beginning, only a cosmetic problem, but unfortunately PADD can no longer display the correct version of AdminLTE.
For this reason an update of the speddtest mod did not cause any changes.
Could I now describe my thoughts clearly? Sorry for my initially wrong description.
@Falconcrest Found the issue, working on it.
@Falconcrest try this
sudo su
cd /opt/pihole/
rm version.sh
https://raw.githubusercontent.com/arevindh/pi-hole/master/advanced/Scripts/version.sh
chmod +x version.sh
rm /etc/pihole/GitHubVersions
pihole -v -a
@arevindh O̵K̵,̵ ̵i̵t̵ ̵w̵o̵r̵k̵s̵.̵ ̵I̵ ̵s̵t̵i̵l̵l̵ ̵h̵a̵d̵ ̵t̵o̵ ̵u̵s̵e̵ ̵w̵g̵e̵t̵,̵ ̵b̵u̵t̵ ̵n̵o̵w̵ ̵t̵h̵e̵ ̵d̵i̵s̵p̵l̵a̵y̵ ̵i̵s̵ ̵c̵o̵r̵r̵e̵c̵t̵.̵ ̵I̵s̵ ̵t̵h̵i̵s̵ ̵a̵ ̵t̵e̵m̵p̵o̵r̵a̵r̵y̵ ̵f̵i̵x̵ ̵t̵h̵a̵t̵ ̵I̵ ̵t̵h̵e̵n̵ ̵h̵a̵v̵e̵ ̵t̵o̵ ̵r̵u̵n̵ ̵e̵v̵e̵r̵y̵ ̵t̵i̵m̵e̵?̵
Edit: Unfortunately, the old state returned after 24 hours. The only thing I did was due to updates from DietPi(Debian) do apt update, apt upgrade, apt dist-upgrade, apt autoremove and apt autoclean. Whether this has now restored the old state, I do not know.
I have now performed the fix again, but I suspect that the adjustment will have disappeared again tomorrow.
Edit 2022-03-12: ...the same procedure as every day... The fix is no longer active again. The version.sh file has been replaced again and GitHubVersions contains the following content again: v5.9 v5.11 v5.14
I have no idea what undoes this fix.
@Falconcrest that's weird. How did you install pihole? Anyway the issue will be fixed with next version for pihole front end
@arevindh The system is DietPi, based on Debian. There you can select and install Pi-hole from a software pool. But ok, I'm waiting for the next version. Thanks!
@Falconcrest seems like dietpi handles installs in their own way, thay might be just deleting the entire codebase and re downloading from git. You can try switching to normal installation using the bash script provided by pihole.
@arevindh After installing the latest update from speedtest mod, the display in PADD and Pi-hole is even more confusing.
root@pihole:~# pihole -v Pi-hole version is v5.9 (Latest: v5.9) AdminLTE version is v5.11.1-2-gf82e5843 (Latest: v5.11) FTL version is v5.14 (Latest: v5.14)
Pi-hole® v5.9, Web v5.11.1-2-825843, FTL v5.14, PADD v3.6.6 [✓] Core [✓] FTL [i] Updates are available.
@Falconcrest Added more change today (Just published release today)
Can you try this
sudo su
cd /var/www/html/admin/
git pull
pihole updatechecker local
@arevindh Yes, this only causes a temporary correction. After a reboot the status was back to the previous one.
But after running
curl -sSL https://github.com/arevindh/pihole-speedtest/raw/master/update.sh | bash
the display was almost correct again, except for the known issue with Web v5.11.1.
@Falconcrest that will be fixed in the next release since.
@arevindh Very good, I'll report then...
I also once made a request in the DietPi forum, maybe someone there has an idea. Here's another answer from the DietPi forum: https://dietpi.com/phpbb/viewtopic.php?t=10186
@Falconcrest Try this, I just deleted and created new tag
sudo su
cd /var/www/html/admin/
git tag -d v5.11
git fetch --tags
git pull
pihole updatechecker local
pihole -v -a
@arevindh Yes, this only causes a temporary correction. After a reboot the status was back to the previous one.
But after running
curl -sSL https://github.com/arevindh/pihole-speedtest/raw/master/update.sh | bash
the display was almost correct again, except for the known issue with Web v5.11.1.
Oops, you were using this update command, the command wasn't updated to fix this issue (the change was specifically for your use case ). Anyway now I added it to the update script.
I can't find any info about an update to v5.11.1 for pihole-web?! https://github.com/pi-hole/AdminLTE/releases/tag/v5.11
Not sure if this is related to the update you made but I’m getting the following when running the Update command.
chmod: cannot access 'version.sh': No such file or directory```
On Mar 17, 2022, at 8:38 AM, itsmesid ***@***.***> wrote:
@arevindh Yes, this only causes a temporary correction. After a reboot the status was back to the previous one.
But after running
curl -sSL https://github.com/arevindh/pihole-speedtest/raw/master/update.sh | bash
the display was almost correct again, except for the known issue with Web v5.11.1.
Oops, you were using this update command, the command wasn't updated to fix this issue (the change was specifically for your use case ). Anyway now I added it to the update script.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
@town3r oh another typo, fixed it. Can you check again ?
@arevindh & @town3r Sorry, I had the same error too, I didn't mention it and then did some steps again manually. I just ran the script again and it works correctly.
Closing this issue
Hello,
first of all the speedtest mod is a small, but nice feature for pi-hole. Unfortunately, I personally have a problem with it. I also use PADD and after installing the mod, I see another web version of pi-hole. In my current case it is version 5.11.1 and no longer 5.11 as in the original. PADD therefore warns: updates are available. It's only a "cosmetic" problem, I know I've changed something, but isn't there a more elegant solution?