(Re)install and Uninstall Failsafe Script

[ipitio]

This is part of https://github.com/arevindh/AdminLTE/pull/70

Features:

• New mod.sh script
  • Unified script
  • Provides failsafe capability
  • Revert to upstream without updating (even without a backup (git checkout))
  • Adds speedtest repo
  • Only installs speedtest if no repo

Fixes:

• Backup all modified files
  • Makes uninstall faster
• Backups use predictable names
  • No more old backups taking up space

[ipitio]

Everything works now!

[town3r]

I got this error when running your install/upgrde script

fatal: HEAD does not point to a branch
Error: Remote revision could not be obtained, please contact Pi-hole Support Additional debugging output:
HEAD detached at v5.18.1

[ipitio]

@town3r oops forgot to sync test branch, should work now

[town3r]

Still getting some errors:

[ipitio]

Hmm now I'm only cloning the last commit, could you try now

[town3r]

No dice.

[ipitio]

what about now

[town3r]

Still getting the HEAD detached error. :(

No more crazy long list of version tags.

[ipitio]

What about now

[town3r]

This is what I'm getting currently:

[ipitio]

Woo! It works! I got rid of those errors but they didn't matter.

[town3r]

[ipitio]

Lol no way they released an update rn. Perfect timing to test how my script would handle a pihole update before the mod is updated for it. And looks like the test passed so that's good

[ipitio]

How have you been running speedtests without speedtest?

If you were using speedtest-cli, previous versions of my script would've removed it.

[town3r]

I have speedtest, so not sure why it said it couldn't find it.

[ipitio]

How did you install it? What instructions did you use to install it or who's script did you use?

[town3r]

Used the install steps from arevindh

https://github.com/arevindh/pihole-speedtest/wiki/Installing-Speedtest-Mod#install-speedtest-cli

Grabbed link to latest version here

https://www.speedtest.net/apps/cli

ie: https://install.speedtest.net/app/cli/ookla-speedtest-1.2.0-linux-armhf.tgz

[ipitio]

Ah, will now account for that

[ipitio]

Can u take a sc of the output now

[town3r]

[town3r]

Ahh your new script added a bad repo

[ipitio]

Yeah ookla is dumb and don't detect os properly, I'm fixing their script. They account for raspbian and get so so close to using Debian.

[town3r]

Is your script trying to reinstall the speedtest app itself and the speedtest pihole mod?

[ipitio]

It's trying to add the speedtest source so that apt knows what speedtest is and stops showing that error. Otherwise the script does exactly what those time stamps say it's doing.

[ipitio]

Try now

[town3r]

[town3r]

Doesn't look like it's auto running the Speedtest hourly like within the settings tho. :(

[ipitio]

Could you click confirm in speedtest settings? Just confirm will do it but you could update too. Should work after, we'll know in 30 min. Simply updating doesn't update/fix the timer cuz sid wanted that to only happen when user selects confirm.

[ipitio]

And then you could send a sc of that cat command

[town3r]

Cat command?

[ipitio]

cat /var/log/pimod.log it's at the bottom of speedtest settings

[town3r]

[ipitio]

Did the Speedtest run, if it didn't I could still maybe fix before next hour.

[town3r]

Looks like it! 🥳

[town3r]

Hmm I'm now seeing this when manually running pihole -up

[ipitio]

I think the local revision thing is because my latest changes aren't under a release, if pihole -up worked before.

Are the DNS issues related to the Mod?

Did running pihole -up work before, even with the mod still installed? If so it might be unnecessary to uninstall the mod before updating pihole.

[town3r]

I think the local revision thing is because my latest changes aren't under a release, if pihole -up worked before. Are the DNS issues related to the Mod?

I think so? Only thing that I've changed has been from your script.

Did running pihole -up work before, even with the mod still installed? If so it might be unnecessary to uninstall the mod before updating pihole.

It did work before. I'll try uninstalling the mod via the settings option, running pihole -up followed by running your script again

[town3r]

Didn't even have to uninstall, actually just ran arevindh's upgrade script and once ran I was able to run pihole -up successfully.

Running your script, brought back the errors from above

[ipitio]

Just added a new tag, if pihole -up works now then it means it'll work when sid merges. It just won't work when updating to my test branch. If it still doesn't work, then ig just don't use it when you have the mod installed lol. Is it vital that it works?

curl mod.sh | sudo bash -s up un uninstalls the mod and updates pihole so you can think of it as an equivalent command. This is the same as ticking the reinstall latest and uninstall boxes.

[town3r]

Any idea why the hourly tests would stop randomly at 11 yesterday?

[arevindh]

That's weird

[town3r]

Looks like it started back up at 08:00 this morning due to me selecting the (Re)install Latest option under Speedtest Settings at like 07:30.

So something must have been off w/ the previous version ¯_(ツ)_/¯

[town3r]

That's weird

Right! Not sure what happened/changed around that time.

¯_(ツ)_/¯

Glad it seems to be happy again since running your fancy (Re)install Latest feature.