AdminLTE 5.0 - Githubissues

arevindh / pihole-speedtest

Pihole Speedtest Mod

https://arevindh.github.io/pihole-speedtest/

MIT License

215 stars 22 forks source link

AdminLTE 5.0 #36

Closed mgarland1988 closed 4 years ago

mgarland1988 commented 4 years ago

What is the process of upgrading from 4.x to 5.0 adminLTE? PiHole -up does not upgrade adminLTE. Would the steps be: Uninstall speed test mod, upgrade adminLTE, then install speed test mod again? Thanks

flipptx commented 4 years ago

did you have any luck? I'm sat at the same right now. can't get it to work with 5.0

Myth0ne commented 4 years ago

Yep you need to run the below commands it updated my web interface.

sudo rm /var/www/html/admin sudo git clone https://github.com/pi-hole/AdminLTE.git /var/www/html/admin pihole -r and select repair

I can't get the speedtest working at the moment I think it needs to be updated.

arevindh commented 4 years ago

@flipptx @mgarland1988 @josh3003 : Updated to v5.0 . I you don't mind, can you update and test it ?

flipptx commented 4 years ago

i don't see the speediest mod after the update just regular pi-hole screen, and the screen now shows this... "Pi-hole Version v5.0 Web Interface Version v4.3.3 (Update available!) FTL Version v5.0" any thoughts? do i need to reinstall the MOD vs just update?

ChrisWNY commented 4 years ago

I used the update (ran it at ~5:30pm EST May 11 2020) command and PiHole is still reading v4.3.3 for the Web Interface version. From the CLI, this is how it's reported (when using the speedtest AdminLTE):

Pi-hole version is v5.0 (Latest: v5.0) AdminLTE version is v4.3.3-508-g25a0f385 (Latest: v5.0) FTL version is v5.0 (Latest: v5.0)

The UI does look identical to version 5.0 and the left-hand menu is now correct (the once-and-done update script however still isn't working properly, reverts PiHole's web UI to 4.3.3).

Speedtest functionality is working and the speedtest data shows up fine, but the version is still out of whack.

Myth0ne commented 4 years ago

@arevindh Hey, I ran the steps again and I have the speedtest mod working on AdminLTE 5.0

Thanks for pushing an update so quickly.

Any chance we can get the new bar graphs to match the rest of the new interface?

Myth0ne commented 4 years ago

Oh yeah it does show web interface is 4.3.3 that's probably just cosmetic as it does show it is up to date in commandline. Probably just another quick update to fix it

arevindh commented 4 years ago

Can you try pihole updatechecker local after a pull on /var/www/html/admin. Will also check and post update .

Reason : Forgot to create a release .

arevindh commented 4 years ago

@josh3003 : Which one will you prefer ? stacked normal

mgarland1988 commented 4 years ago

@josh3003 : Which one will you prefer ?

@arevindh This looks brilliant! :) Thank you everyone with your help and support I am yet to update, so I can test from AdminLTE version 4.3.3. Please let me know what steps do you want me to carry out, and I can test the process.

Thank you all

arevindh commented 4 years ago

@mgarland1988 : I think second one is better , what do you think ?

You can use manual instructions

https://github.com/arevindh/pihole-speedtest/wiki/Updating--Speedtest-Mod#manual-instructions

mgarland1988 commented 4 years ago

@mgarland1988 : I think second one is better , what do you think ?

You can use manual instructions

https://github.com/arevindh/pihole-speedtest/wiki/Updating--Speedtest-Mod#manual-instructions

@arevindh Thank you so much for all your support - this works perfectly :)

I will close this case - really appreciate all your hard work

I agree, the second graphic is better! 👍

arevindh commented 4 years ago

Please pull admin once more i have updated line chart to bar chart