search

arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
215 stars 22 forks source link

Retry failed aborting #39

Closed ipitio closed 4 years ago

ipitio commented 4 years ago

This is on a Google Cloud Compute Engine VM on Ubuntu 18.04.4 LTS. The issue occurred when I had pihole v4 and still occurs after upgrading to v5.

speedtest-cli runs fine, returning:

Retrieving speedtest.net configuration...
Testing from Google Cloud...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by Cox - Nova (Fairfax, VA) [21.49 km]: 13.976 ms
Testing download speed................................................................................
Download: 1192.34 Mbit/s
Testing upload speed................................................................................................
Upload: 542.49 Mbit/s

sudo pihole -a -sn however, returns this:


Testing Speed
/var/www/html/admin/scripts/pi-hole/speedtest/speedtest.sh: line 320:  4517 Killed                  $cmd > $log
/var/www/html/admin/scripts/pi-hole/speedtest/speedtest.sh: line 320:  4675 Killed                  $cmd > $log
Connection Failed Retry after 30 sec Connection Failed Retry failed aborting

The log shows this:

Retrieving speedtest.net configuration...
Testing from Google Cloud...
Retrieving speedtest.net server list...
Selecting best server based on ping...
Hosted by Xiber LLC (Washington, DC) [31.89 km]: 13.271 ms
Testing download speed................................................................................
Download: 1244.80 Mbit/s
Testing upload speed........................................................................
arevindh commented 4 years ago

Can you update speedtest mod and retry?

ipitio commented 4 years ago

Updated. Now speedtest runs fine, but sudo pihole -a -sn still terminates on the same line.

arevindh commented 4 years ago

sudo pihole -a -sn uses old method (Python). Will fix it in next release.

Hope you have enabled Official CLI mode.

https://www.reddit.com/r/pihole/comments/gw85xh/pi_hole_speedtestmod_now_supports_official/

ipitio commented 4 years ago

I don't see the drop down menu.

image

arevindh commented 4 years ago

@P8Kcv6n . follow these Instructions

ipitio commented 4 years ago

Yeah I installed speedtest-cli and tried the one-click update, didn't work. Also tried manually updating, reinstalling the mod, and rebooting.

arevindh commented 4 years ago

Tried clearing browser cache ? May be another another browser.

Can you post output of sed -n '1453,1460p;1461q' /var/www/html/admin/settings.php .

Hope you have install Speedtest CLI https://www.speedtest.net/apps/cli .

ipitio commented 4 years ago

Yes, that's the Speedtest CLI that I installed. I've tried deleting the website data for pi.hole in Chrome and Safari.

The output of that command is:

                                </div>
                            </form>
                        </div>
                    </div>
                </div>

Exciting Edit: I just tried manually updating again, and now that command outputs what you were expecting; the option appears on the web interface. It appears to be working correctly... Whoa the download speed is so much higher haha.

arevindh commented 4 years ago

Seems codebase is not updated. Please run and post output sudo su cd /var/www/html/admin git remote -v git status git pull

ipitio commented 4 years ago

As I mentioned in the edit in my last comment, the file updated on my last attempt.

But now I've noticed that the speed test runs hourly even when disabled. Should I post a separate issue? I tried selecting the python method to stop it, but it seems to work now too!

arevindh commented 4 years ago

@P8Kcv6n Seems I missed that one when implementing official speedtest. Fixed now . 

sudo su
cd /opt/pihole/
rm webpage.sh
wget https://github.com/arevindh/pi-hole/raw/master/advanced/Scripts/webpage.sh
chmod +x webpage.sh
ipitio commented 4 years ago

That didn't stop them, tried both disabling in the web ui and in the shell with sudo pihole -a -s 0

arevindh commented 4 years ago

@P8Kcv6n Seems I missed that one when implementing official speedtest. Fixed now .

sudo su
cd /opt/pihole/
rm webpage.sh
wget https://github.com/arevindh/pi-hole/raw/master/advanced/Scripts/webpage.sh
chmod +x webpage.sh

@P8Kcv6n can you try same steps now ?

ipitio commented 4 years ago

Sorry for the late reply, but that worked--it disables now. Everything seems to be working well, including with my local pihole machine.