search

arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
216 stars 22 forks source link

Show failed speedtests as 0? #43

Closed brycedjohnson closed 4 years ago

brycedjohnson commented 4 years ago

Might be nice to show failed speedtests as dl/up 0 in the graph? Had an internet outage today from for 11 hrs and looked back to see when the last successful test was run to see when it started and ended and if it was was working at all in between.

Thanks for the great work! Very useful!

arevindh commented 4 years ago

@brycedjohnson Let me try.

arevindh commented 4 years ago

@brycedjohnson : Feature is now added in the dev branch , wil you be able to test before it goes live ?

brycedjohnson commented 4 years ago

Sure thing! Thanks!

On Sat, Jul 25, 2020, 10:13 AM itsmesid notifications@github.com wrote:

@brycedjohnson https://github.com/brycedjohnson : Feature is now added in the dev branch , wil you be able to test before it goes live ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arevindh/pihole-speedtest/issues/43#issuecomment-663872571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATWZ6IVSGWFUBRHJZA4KPDR5MADJANCNFSM4OF3UI7Q .

arevindh commented 4 years ago 
sudo su
cd /var/www/html/admin
git pull
git checkout dev

Now go to settings set an invalid speedtest id like 3333333

Test by running sudo "/var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh"

karimnouh commented 4 years ago

@arevindh Tested and confirmed to work. Thanks for making it happen. image image

brycedjohnson commented 4 years ago

I'm getting a error when I run the script root@raspberrypi:/var/www/html/admin# /var/www/html/admin/scripts/pi-hole/speedtest/speedtest-official.sh Testing with 10051 usage: speedtest [-h] [--no-download] [--no-upload] [--bytes] [--share] [--simple] [--csv] [--csv-delimiter CSV_DELIMITER] [--csv-header] [--json] [--list] [--server SERVER] [--exclude EXCLUDE] [--mini MINI] [--source SOURCE] [--timeout TIMEOUT] [--secure] [--no-pre-allocate] [--version] speedtest: error: unrecognized arguments: -s 10051 --accept-gdpr --accept-license -f json-pretty 2020-07-28 09:38:09 2020-07-28 09:38:10 0 Error: near ",": syntax error I'm on 5.1? Maybe there is an issue there?

arevindh commented 4 years ago

@brycedjohnson can you update and try

https://github.com/arevindh/pihole-speedtest/wiki/Updating--Speedtest-Mod

karimnouh commented 4 years ago

@brycedjohnson You probably currently have speedtest-cli by sivel aka Python version in the web GUI. Meanwhile, speedtest-official.sh uses 'Speedtest CLI' from Ookla https://www.speedtest.net/apps/cli.

brycedjohnson commented 4 years ago

@arevindh I did the update and still getting that syntax error.

@karimnouh That sh script runs the official speedtest directly. I can run speedtest.sh script which runs the python script and that one works to get the speedtest, although I didn't get the no internet in the database when trying it with a different invalid server, or disconnected my pi from the internet during the test.

Version from the web interface: Pi-hole v5.1.1 Web Interface v5.1 FTL v5.1

edit: After updating I forgot to checkout dev let me try that...

brycedjohnson commented 4 years ago

@karimnouh Oops yes you were right. I had the Speedtest official installed at one point and it was working, but must have reverted back to the python script at some point.

Also glossed over the first step somehow just now when reinstalling. Doh. Install Speedtest CLI (Important)

@arevindh Tested it and it works now! Sorry about the confusion!

arevindh commented 4 years ago

Thanks for testing.

arevindh commented 4 years ago

@brycedjohnson @karimnouh: Line char or bar chart is better? ( Changed from bar to line chart along with this change).

brycedjohnson commented 4 years ago

Line chart for sure! I saw that and liked it better.

On Tue, Jul 28, 2020, 8:15 PM itsmesid notifications@github.com wrote:

@brycedjohnson https://github.com/brycedjohnson @karimnouh https://github.com/karimnouh: Line char or bar chart is better? ( Changed from bar to line chart along with this change).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arevindh/pihole-speedtest/issues/43#issuecomment-665390354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATWZ6LVYFIDBR6XZBJ6LMTR56A5HANCNFSM4OF3UI7Q .

karimnouh commented 4 years ago

Agreed the line chart works way better for a time series.