arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
215 stars 22 forks source link

5.1 Update - unable to change to Dark theme from Settings #47

Closed ChrisWNY closed 4 years ago

ChrisWNY commented 4 years ago

After updating to the 5.1 Admin UI for pihole-speedtest, pihole > settings > API/Web Interface > Interface Appearance -- changing to "Dark theme" does set the Dark theme within that page, but the setting/variable for the theme is not saved beyond that. Navigating back to the Dashboard loads the light theme, and going back to the API/Web Interface setting also shows that the UI reverts to the light theme again.

Though I'm not 100% sure where the theme variable is stored, I'm presuming it should go into /etc/pihole/setupVars.conf. For now, I worked around the issue by saving /var/www/html/admin/style/themes/default-dark.css to default-light.css, after making backups of the originals. Just a quick hack to ensure the dark theme loads regardless of which theme is selected in Settings.

arevindh commented 4 years ago

Try : https://github.com/arevindh/pihole-speedtest/wiki/Updating--Speedtest-Mod

ChrisWNY commented 4 years ago

Manual or one-click update?

curl -sSL https://github.com/arevindh/pihole-speedtest/raw/master/update.sh | bash

arevindh commented 4 years ago

try manual

ChrisWNY commented 4 years ago

Manual update worked.

Thanks for the quick follow-up. Bought you a few coffees for your work and efforts on maintaining pihole-speedtest.

arevindh commented 4 years ago

@ChrisWNY Thanks a lot.