arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
215 stars 22 forks source link

ETA on update for Pi-hole 5.2? #65

Closed ChrisWNY closed 3 years ago

ChrisWNY commented 3 years ago

New core/web UI/FTL was released today. Looking forward to seeing the latest Pi-hole-Speedtest update for it!

ChrisWNY commented 3 years ago

After updating Pi-Hole (following manual update instructions), seems that the existing Pi-hole Speedtest works perfectly fine with the new updates...though the Web UI reports 5.1.1. Looks like there were a number of updates to the new Web UI.

https://github.com/pi-hole/AdminLTE/releases/tag/v5.2

Myth0ne commented 3 years ago

Think it will need an update for new installs and checkouts. Having the problem now after the upgrade.

arevindh commented 3 years ago

@ChrisWNY working on it

arevindh commented 3 years ago

@ChrisWNY @josh3003 . Updated, can you check and confirm.

ChrisWNY commented 3 years ago

Seems to be working...version info is correctly reported, the new local DNS records menu (including the new CNAME feature) is working as well from initial testing. Since I had already run the Pihole update, I only ran the manual commands to update the Admin repo (from here), the webpage.sh script, and ran the updatechecker to update version info.

Will test more thoroughly during the morning EST and will report back if I run into any issues.

Thanks for the quick turnaround!

Myth0ne commented 3 years ago

May need another quick update. Pi-hole Core/Web v5.2.1 and FTL v5.3.2 released.

ChrisWNY commented 3 years ago

Yep, Pi-hole was updated yet again today. On the upside, the only update to the web Admin was some documentation. Doesn't appear they made any logic or feature changes to the Admin UI.

If you follow the update procedure manually (documentation is on this GitHub page), you can revert Pi-hole to default, run pihole -up, let it update everything, then replace Pihole's Admin UI and webpage.sh with the speedtest version. If you don't run the updatechecker afterward, you won't get that annoying red glow on the bottom of your Pi-hole webpage showing that there's a newer version out there. Just a temporary workaround that's purely cosmetic.

Myth0ne commented 3 years ago

Yeah that annoying red flashing update available is annoying lol. I hadn't tested speedtest yet will just wait until 5.2.1 is created and will implement then. Kind of annoying there is probably some check somewhere and you could just hardcode the version number to satisfy that red glow.

ChrisWNY commented 3 years ago

I've updated and applied the speedtest Admin repo to the latest Pihole build and everything works fine. You won't trash your Pihole install as all you're doing is overwriting some web pages and a script with the custom speedtest version. If you follow the manual update process it's very simple to revert and only takes a few seconds to do so.

Every time I update Pi-hole (using pihole -up) I test out the standard Pihole install before I grab the Speedtest Admin repo just to make sure Pi-hole is working in its standard form. Just backup the Admin directory and webpage.sh before you apply the Speedtest Admin repo and you're golden if you ever want to revert back to the Pi-hole default.

I've never had any problems doing things that way. Even if you don't backup the Admin directory you can do a git clone and grab the Pihole Admin web UI in a matter of a few seconds.

arevindh commented 3 years ago

@josh3003 @ChrisWNY : Just some minor changes . Will update after work hours.

arevindh commented 3 years ago

@josh3003 @ChrisWNY Updated

ChrisWNY commented 3 years ago

I grabbed the latest Admin LTE - pihole -v is outputting the following after update: AdminLTE version is v5.2-6-g7a9e44a9

This causes the web UI to think there is an update still available (and reports the Web UI as 5.2 instead of 5.2.1). Just wanted to double-check. Thanks.

arevindh commented 3 years ago

@ChrisWNY Check now, forgot to create the release.

ChrisWNY commented 3 years ago

That worked...version reported properly, everything seems good to go. I'll close this one. Thanks for the quick updates and follow-ups!