Angles of time on dashboard graph not present

arevindh / pihole-speedtest

Pihole Speedtest Mod

https://arevindh.github.io/pihole-speedtest/

MIT License

215 stars 22 forks source link

Angles of time on dashboard graph not present #72

Closed town3r closed 2 years ago

town3r commented 3 years ago

The time labels of the dashboard graph are not angled like the others resulting in text being covered.

arevindh commented 3 years ago

@zelrone Can you take a look at it.

town3r commented 3 years ago

Is there a specific file that has the configuration of how things are displayed on the graph that I could test a few things?

arevindh commented 3 years ago

@town3r I tried a few things but the current one is the best I could do.

I am making a new standalone version with better graphing libraries.

town3r commented 3 years ago

Guessing no, but is it possible to just copy the graph style of Total Queries & Client activity?

I'm digging into the AdminLTE-master files a bit to see if i can find where you added the Speedtest graph. Was the code to add the speedtest graph just merged with the existing datatables css file or is there a separate new one?

Apologies for all the questions. first time really looking at the files and seeing where things are

arevindh commented 3 years ago

@town3r Since there is not date, the Total Queries & Client activity graph looks nice, I tried the same style the result was not good. Js file is available here https://github.com/arevindh/AdminLTE/blob/master/scripts/pi-hole/js/speedtest.js.

If you are successful a pull request is appreciated.

town3r commented 3 years ago

Thank you! Super new to JS and really Github was well so no idea how to perform a pull request. Did find removing Do from the (itemdate).format("Do HH:mm") line seems to help when viewing on mobile. and modifying the maxTicksLimit from 10 to 20 helped as well.

Haven't been able to figure out how to change the color of the text or have them rotate to fit correctly yet.

arevindh commented 3 years ago

@town3r now it's missing date right?

town3r commented 3 years ago

Yeah, which I'm ok with.

I was more wanting it to mirror what the other graphs look like & display on the admin dashboard.

When it's only showing the last 24 some hours the date isn't really needed.

arevindh commented 3 years ago

When it's only showing the last 24 some hours the date isn't really needed.

But it is not good for more than a day. I will keep it as it since it needs to show more days.

town3r commented 3 years ago

Hit up the discourse.pi-hole.net forum to see if maybe someone knows how the Pihole devs configured their fancy dashboard graphs.

https://discourse.pi-hole.net/t/pihole-dashboard-graph-configuration-file-location/46817

github-actions[bot] commented 2 years ago

Stale issue message

town3r commented 2 years ago

Can this be reopened?