arevindh / pihole-speedtest

Pihole Speedtest Mod
https://arevindh.github.io/pihole-speedtest/
MIT License
218 stars 22 forks source link

Pi-hole FTL v5.9, Web v5.6 and Core v5.4 released #91

Closed town3r closed 2 years ago

town3r commented 2 years ago

https://pi-hole.net/2021/09/11/pi-hole-ftl-v5-9-web-v5-6-and-core-v5-4-released/

arevindh commented 2 years ago

@town3r will update today.

flipptx commented 2 years ago

did this get updated? i just ran update and i don't see the V numbers update yet

arevindh commented 2 years ago

@flipptx Just merged now. Everything was ready I just needed to test some more . @town3r Updated to latest version

arevindh commented 2 years ago

@town3r @flipptx Let me know if you encounter any issues.

ChrisWNY commented 2 years ago

Hey Sid - I've grabbed the latest speedtest admin repo. The web UI version info is reported correctly, however there is a minor inconsistency in the Settings page...

https://github.com/pi-hole/AdminLTE/releases/v5.6

"footer.php: move FTL before Web Interface #1854 Remove adlists tab from settings page #1845"

Per the release notes, it looks like the Adlists tab was supposed to be removed from Settings, but it's still showing up (after installing the latest speedtest admin repo). FTL version is still being reported after web UI version in the footer - these are just minor cosmetic issues, but should've changed based on the web 5.6 release notes. Not sure if this is the same using the stock Pi-hole 5.6 web UI as I was still using the older speedtest admin repo (5.5.1) after updating Pi-hole FTL/core. This may just be pointing out that there are still some older php files sitting in the newest speedtest admin repo. Otherwise things seem to be running fine overall.

town3r commented 2 years ago

Thinking I uninstalled it wrong 5 days ago when i wanted to get the update right away. Getting the following:

root@ToWn3r-Pi:/var/www/html# mv admin org_admin
mv: cannot move 'admin' to 'org_admin/admin': Directory not empty
root@ToWn3r-Pi:/var/www/html# git clone https://github.com/arevindh/AdminLTE admin
fatal: destination path 'admin' already exists and is not an empty directory.

¯_(ツ)_/¯

Using the update script seems to have worked tho. curl -sSL https://github.com/arevindh/pihole-speedtest/raw/master/update.sh | bash

ChrisWNY commented 2 years ago

Try rm -rf org_admin as root before running the manual update commands. If those backup directories are still there those commands will throw an error.

Also try going through the manual steps, rather than using the update script...that way you can see at which point a command, etc. might fail.

https://github.com/arevindh/pihole-speedtest/wiki/Updating--Speedtest-Mod

arevindh commented 2 years ago

Hey Sid - I've grabbed the latest speedtest admin repo. The web UI version info is reported correctly, however there is a minor inconsistency in the Settings page...

https://github.com/pi-hole/AdminLTE/releases/v5.6

"footer.php: move FTL before Web Interface #1854 Remove adlists tab from settings page #1845"

Per the release notes, it looks like the Adlists tab was supposed to be removed from Settings, but it's still showing up (after installing the latest speedtest admin repo). FTL version is still being reported after web UI version in the footer - these are just minor cosmetic issues, but should've changed based on the web 5.6 release notes. Not sure if this is the same using the stock Pi-hole 5.6 web UI as I was still using the older speedtest admin repo (5.5.1) after updating Pi-hole FTL/core. This may just be pointing out that there are still some older php files sitting in the newest speedtest admin repo. Otherwise things seem to be running fine overall.

Will check it tomorrow. Thanks for the report.

town3r commented 2 years ago

Looks like pihole deva didn't get to it.

https://reddit.com/r/pihole/comments/pqj6ox/web_interface_56_still_showing_adlists_tab_on_the/

ChrisWNY commented 2 years ago

^ Thanks for confirming. I never verified the 5.6 web UI (pi-hole default), but suspected unless some older PHP files were left in the speedtest admin repo, the problem was with the pi-hole web UI itself.

Sid - you can probably close this one out, I haven't run into any issues since updating a couple of days ago.