search

arfbtwn / banshee

http://banshee.fm/
MIT License
6 stars 4 forks source link

TreeView scrolling reset on track change #1

Closed arfbtwn closed 7 years ago

arfbtwn commented 7 years ago

The TreeView resets its scrolling to row 1 on most track changes. This doesn't happen on every change, occasionally the view scrolls correctly to the selection. Appears to be a side effect of the model reload performed when track details are synchronised to disc.

arfbtwn commented 7 years ago

Should be corrected with an experimental submodule update: https://github.com/arfbtwn/banshee/commit/c05dcf08c1b9a8498cd6ebd0104b0d1cba7443dd

This is a consequence of having to reset the model - in Banshee there is no granularity to the OnModelReloaded signal so it's the only reliable way (I've found) to ensure we're looking at the right data and avoid iterators becoming invalid. Tried Foreaching the model but the deleted signal didn't have the desired effect and blank rows remained, instead we reset the scroll but we might revisit this later.

arfbtwn commented 7 years ago

Yep, looks corrected now :+1: