arfbtwn
commented
7 years ago Just a comment to highlight that this isn't a reflection on recent patches, which have been ideal.
But also to record that in my advice on a gstreamer pull request about tags not being assembly names and being all lower case, as per GNOME guidelines, looks like I was wrong - there are plenty of instances in the logs where the assembly name is used as a tag.
As anyone who has had a patch reviewed on bugzilla.gnome.org will know, there are some contribution guidelines for Banshee (and GNOME projects in general) but this information is tucked away in various places [1,2] and some can cause surprise to casual GitHub users as the flow is a bit different including an (AFAIK) unwritten rule against merges.
We should make sure the guidelines are presented to avoid surprise when reviewing pull requests.
[1] http://banshee.fm/contribute/write-code/ [2] https://wiki.gnome.org/Git/CommitMessages