search

arfbtwn / banshee

http://banshee.fm/
MIT License
6 stars 4 forks source link

Feature/fixes #14

Closed arfbtwn closed 6 years ago

arfbtwn commented 7 years ago

Various fixes, some refactoring and the Mono.Posix build reference update

Carbenium commented 7 years ago

Ah damn. I thought you could review single commits... I only reviewed 033e1aab50e490eadfb6dc2851d86698e6968df8 Life is a bit busy right now...

arfbtwn commented 7 years ago

No problem, I just had a bit of a binge this weekend and pushed out some rebased branches (sorry for that) to try and slim down the feature/lite branch into just its required commits for the new UI, same for the Hyena repo.

This will sit for a bit and I'll take another look at it later, especially 9d952b3 that really needs splitting in two.

I have some other ideas for the autotools update too, we'll see :+1:

Carbenium commented 6 years ago

@arfbtwn Any chance we could get cb0d2e5 and a41bb41 into master? I think it would make my life a bit easier to base the notification library work directly on those.

EDIT: ff055914a2a1f54aa7f12a8f8e31df38d98647de is definitely a candidate, too.

arfbtwn commented 6 years ago

cb0d2e5 needs a bit more work - skills wise I'm okay, I just need to finish mapping the dependencies and automatically enabling extensions/other features. As it is it's great for build scripts that pass all the use/with flags but otherwise the user ends up with a very minimal build.

a41bb41 - sure thing :+1:

yeah, ff05591 is a good candidate - I'll push a feature/bugs branch and start cherry-picking choice patches into there.

arfbtwn commented 6 years ago

Shame, GH is doing some magic again, some of these commits are already in master - it really doesn't agree with my re-ordering of commit history 😆

I'll do my best to improve f51e4c2 and 0e8bec0 - after that we should have an awesome auto-tools build system and all that'll be left here will be little bug fixes in a decent order.

EDIT: for the Notifications stuff; if you're wondering how to switch the project files between using a system library or the internal version, you could try and tackle that but we'll almost definitely need auto-tools generation for some things - an idea might be some conditional csproj declarations and then we can substitute the condition expressions from the configure script.

arfbtwn commented 6 years ago

Remaining commits decomposed into: #41 & #42