Closed Carbenium closed 7 years ago
Thanks. Still trying to get accustomed to the code base, so excuse me for the lengthy discussion.
On a side note: GitHub has the feature to squash the commits directly during the merge. Look at the arrow on the merge button.
Knew it - thing put the pull request title in the commit message for the squash. I really hate that button - just force-pushed the right commit (4f39dd5) for this back out.
Don't worry about going through a bit of discussion - that's what issues and pull requests are for, thanks again for the input :+1:
I haven't looked at the native player engine but looking through your commit logs it looks like I made the right choice in sticking with it
Should I create an issue to track this?
Perhaps, yes, I noticed you'd removed the GStreamerSharp backend - I think your message said the bindings library was unmaintained
Exactly. It's unmaintained, doesn't ship with any large distro and it couldn't play a track. So pretty useless in my opinion :smile:
Agreed, did you get that behaviour even with their master branch?
I remember experimentally trying it out - had to make some changes to Banshee to get it to compile, see bb1ac56, think I tried it out and it was working at the time.
Technically this isn't really necessary but it help to keep valgrind logs cleaner