search

arfbtwn / banshee

http://banshee.fm/
MIT License
6 stars 4 forks source link

Move Notifications to its own library #34

Closed Carbenium closed 6 years ago

Carbenium commented 6 years ago

Alright. I just ran the code cleanup using our rules (PR with couple of changes incoming).

The reviewing experience might just have become worse but let's see what you say :wink: If you're okay with the last commit (06ad6f8) I'm gonna squash it with the previous.

arfbtwn commented 6 years ago

Looks great to me :+1:

I gave it a slight massage and reduced it to the new library addition (all in) and then the auto-formatting, only thing I did to that was restore some line separation to the using declarations.

Since you're away I pushed this out and created a fresh pull-request, #40, if you're happy with it chuck an approval on and I'll merge it in.

arfbtwn commented 6 years ago

merged #40, cheers