arfbtwn / banshee

http://banshee.fm/
MIT License
6 stars 4 forks source link

Feature/now playing #43

Closed arfbtwn closed 5 years ago

arfbtwn commented 6 years ago

There were a number of problems with the NowPlaying extension making its behaviour, particularly with respect to GUI components, a bit confusing. In addition there were a number fo hack comments indicating quality issues. It appears to have suffered some bit-rot as functionality was added and the extension was expanded.

We address a number of things:

Finally we prevent background pattern clearing in the Gdk.Window we ask GStreamer to draw on, this causes an XLib error on reparenting when the HeaderBar is in use in the lite interface and the only reason I can find for clearing the property is the original GStreamer C example code for the video overlay.

arfbtwn commented 6 years ago

Would be grand to test this patch out with the regular interface in master branch once that's semi-up-to-date. Couple of highly visible outstanding issues:

Stretch:

arfbtwn commented 6 years ago

20 should now be resolved in this branch

arfbtwn commented 6 years ago

It'll be a little shorter once all the debugging statements I added are removed before merging...