Feature/bugs - Githubissues

arfbtwn commented 6 years ago

Resolves #49, @nicman23 can you confirm if you've seen that issue and if so, whether this resolves it for you or has any other unwanted effects?

nicman23 commented 6 years ago

sure, anything in particular ?

nicman23 commented 6 years ago

can you please fix some compiling errors when compiling with gtk2 and gtk3 libs in system ie:

MCS   ../../../bin/Banshee.Dap.AppleDevice.dll
error CS1703: An assembly `atk-sharp' with the same identity has already been imported. Consider removing one of the references
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-2.0/atk-sharp.dll (Location of the symbol related to previous error)
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-3.0/atk-sharp.dll (Location of the symbol related to previous error)
error CS1703: An assembly `gdk-sharp' with the same identity has already been imported. Consider removing one of the references
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-2.0/gdk-sharp.dll (Location of the symbol related to previous error)
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-3.0/gdk-sharp.dll (Location of the symbol related to previous error)
error CS1703: An assembly `glib-sharp' with the same identity has already been imported. Consider removing one of the references
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-2.0/glib-sharp.dll (Location of the symbol related to previous error)
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-3.0/glib-sharp.dll (Location of the symbol related to previous error)
error CS1703: An assembly `gtk-sharp' with the same identity has already been imported. Consider removing one of the references
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-2.0/gtk-sharp.dll (Location of the symbol related to previous error)
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-3.0/gtk-sharp.dll (Location of the symbol related to previous error)
error CS1703: An assembly `pango-sharp' with the same identity has already been imported. Consider removing one of the references
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-2.0/pango-sharp.dll (Location of the symbol related to previous error)
/usr/lib/pkgconfig/../../lib/mono/gtk-sharp-3.0/pango-sharp.dll (Location of the symbol related to previous error)

arfbtwn commented 6 years ago

specifically the issue I logged in #49 - empty browser when you first open the program or enable the setting.

Feel free to raise any other issues as you see them - I wasn't aware of this one until I did some testing of the build system update that doesn't have TreeView in it.

nicman23 commented 6 years ago

not opening a new issue just because i am not sure if it is a bug but with --disable-gst_sharp, --enable-gst-native is not assumed! so you end up with a music player that cannot play music :P
genre browser is empty no matter what i do

arfbtwn commented 6 years ago

Yeah I noticed the blank genre browser too - I'll take a look, cheers :+1:

nicman23 commented 6 years ago

also in media panel on the albums i cannot scroll

arfbtwn commented 6 years ago

I just tested it and I can scroll okay, any reproduction steps for that?

nicman23 commented 6 years ago

e: copy paste to separate issue

arfbtwn commented 6 years ago

pretty sure I've seen that behaviour when using the album browser in the regular program window, would you raise it as a separate issue please?

Also, can you let me know if #49 was ever an issue for you and if this branch fixes that and the empty genre browser?

nicman23 commented 6 years ago

for #49 no sorry never had it.

arfbtwn / banshee

Feature/bugs #50