Closing media panel does not exit banshee

[nicman23]

and if you do not have the notification icon you cannot close with without killing the pid :P

[arfbtwn]

I did a bit of testing while producing the patch to fix this and found another workaround - running banshee normally causes the dbus signal to show the main window again :)

Let me know what you think of the patch though and we'll get it merged.

[nicman23]

at the time i cannot compile without webkitgtk and the compilation time for it (there are no bin packages for it in arch) is forbidding :(.

[arfbtwn]

indeed... you can pass --disable-webkit to disable building of those parts temporarily for the test

[nicman23]

checking for boo >= 0.8.1... no
configure: error: Requires webkit

./configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var \
              --disable-gst_sharp \
              --enable-gst-native \
              --disable-docs \
              --disable-webkit \
              --disable-static \
              --disable-scrollkeeper \
              --disable-schemas-install \
              --disable-boo \
              --enable-daap \
              --enable-remoteaudio \
              --disable-youtube \
              --disable-gio \
              --disable-gio_hardware \
              --disable-user-help \
              --enable-bpm \
              --enable-coverart \
              --enable-filesystemqueue \
              --enable-fixup \
              --enable-internetarchive \
              --enable-internetradio \
              --enable-lastfm \
              --enable-lastfmstreaming \
              --enable-librarywatcher \
              --enable-mediapanel \
              --enable-minimode \
              --enable-miroguide \
              --enable-mpris \
              --enable-multimediakeys \
              --enable-playqueue \
              --enable-nowplaying \
              --enable-notificationarea \
              --enable-opticaldisc \
              --enable-podcasting \
              --enable-playermigration \
              --with-vendor-build-id=ArchLinux

[arfbtwn]

Can you paste the full output somewhere? (pastebin, for example) I tried your configure invocation on my system and it was fine - although I used autogen.sh instead of the straight configure.

Are you trying this through Arch's version of emerge? - if you know git that would be faster.

[nicman23]

sure here https://pastebin.com/0yuA1RgT

it is not emerge just a pkgbuild

e: output https://pastebin.com/Qy2k4ku9 (this time i used ./autogen.sh not autoreconf -fvi

[arfbtwn]

right... I see - I thought your build was based on master branch. The patch for this is merged into feature/lite as well but there is a huge change in the build system too so a lot of the configure flags are different. See ./configure --help.

Update your build script to use feature/mediapanel and you'll get master plus that single patch and stick with autogen.sh.

[nicman23]

in the prepare function i have as a temp hack git checkout feature/lite

e: feature/mediapanel configure works , lite doesn't

e2: build fails with:

  MCS   ../../../bin/Banshee.Services.dll
./Banshee.Preferences/Collection.cs(49,21): error CS0104: `CollectionExtensions' is an ambiguous reference between `System.Collections.Generic.CollectionExtensions' and `Hyena.Collections.CollectionExtensions'
/usr/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error)
/home/nikos/Public/banshee-git/src/banshee/src/Core/Banshee.Services/../../../bin/Hyena.dll (Location of the symbol related to previous error)
./Banshee.Preferences/Collection.cs(49,42): error CS0117: `System.Collections.Generic.CollectionExtensions' does not contain a definition for `SortedInsert'
/usr/lib/mono/4.5/mscorlib.dll (Location of the symbol related to previous error)
Compilation failed: 2 error(s), 0 warnings
make[4]: *** [Makefile:1274: ../../../bin/Banshee.Services.dll] Error 1
make[3]: *** [Makefile:544: all-recursive] Error 1
make[2]: *** [Makefile:548: all-recursive] Error 1
make[1]: *** [Makefile:641: all-recursive] Error 1
make: *** [Makefile:569: all] Error 2

e3: builds with a

sed 's/CollectionExtensions/Hyena.Collections.CollectionExtensions/g' -i src/Core/Banshee.Services/Banshee.Preferences/Collection.cs

[arfbtwn]

CollectionExtensions was only added in .NET Core but I don't think building against that will cause any real issues.

Ignore feature/lite for now - after configuring and building from feature/mediapanel does the patch have the desired effect?

[nicman23]

both build but both need the replacement in the previous comment. actually listening to music now with the mediapanel.

it did freeze once but that might be due to my fault, needs more testing. also https://aur.archlinux.org/packages/banshee-git/ if you care add it in the readme.md

[arfbtwn]

Merged #59