search

arfbtwn / banshee

http://banshee.fm/
MIT License
6 stars 4 forks source link

Feature/zoom #65

Closed arfbtwn closed 6 years ago

arfbtwn commented 6 years ago

Hey @Carbenium, cheers for re-opening #64. I think I was holding off because of worry about the added P/Invoke function but thinking about it this morning I was missing a safe assumption; if we see a 4 for the direction then the user's GDK3 definitely has the required function - in short let's get this one merged.

I tried to do a test with the context window (and your original two patches) but even passing --smooth-scroll when running and pressing Ctrl while scrolling I couldn't get it to zoom, I think it's to do with my touch pad TBH and I don't have a mouse with a wheel to hand. Would have been nice to confirm the fix but if it works for you then I'm happy.

I did a massage of the code clean-up to remove a couple of the if statement compressions it did and a formatting update in a new commit for that ugly nested if statement where we execute the fixup Javascript, I think it's equivalent - if you're cool with those changes I'll merge it in.

Carbenium commented 6 years ago

Hey @arfbtwn, just gave it another shot. Seems to work for me. :smile:

arfbtwn commented 6 years ago

Cool, assuming that's a :shipit: :)