Closed GabePaciocco closed 2 years ago
Hi Gabriele! Thanks for adding yourself to the website. I look forward to working with you in near future.
I like the level of detail in your PR description. This is about the level of detail we expect for PRs (Obviously the bigger your PR, the more details you will have to give)
Don't forget to mark the checkbox for "New feature" under "Types of Changes". Also, if you've run the website on your local machine and it works, you should check the "All new and existing tests pass" box.
Make sure to take a look at the comment I left regarding adding your photo!
.swp
files,
etc.)?Good points from Olek! I would also add that your PR should include the picture of you as well. It seems to have been lost in the shuffle, but it should be added in the same location as you're directing it to in the pic:
line
@nsryan2 @yardasol I think I have resolved your comments let me know if there are any further edits needed.
@nsryan2 @yardasol are your review comments resolved now?
It all looks good to me, sorry @GabePaciocco I totally forgot about this. It looks like you've addressed @yardasol's comments too, but I'll let him confirm that!
Summary of changes
This PR was made to add Gabriele Paciocco's Personal information to the group website. This change will add my picture, name, as well as contact information for refernece.
Types of changes
Associated Issues and PRs
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the Review Checklist before they begin their review.