Closed gwenchee closed 5 years ago
Hello @gwenchee! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
d3ploy/plotter.py
Line 6:80: E501 line too long (80 > 79 characters) Line 6:81: W291 trailing whitespace Line 7:32: W291 trailing whitespace Line 12:69: W291 trailing whitespace Line 16:27: W291 trailing whitespace Line 18:1: W293 blank line contains whitespace Line 26:80: E501 line too long (85 > 79 characters) Line 56:80: E501 line too long (80 > 79 characters) Line 57:80: E501 line too long (80 > 79 characters) Line 57:81: W291 trailing whitespace Line 58:32: W291 trailing whitespace Line 63:69: W291 trailing whitespace Line 64:45: W291 trailing whitespace Line 67:27: W291 trailing whitespace Line 69:1: W293 blank line contains whitespace Line 74:35: E231 missing whitespace after ',' Line 75:45: E251 unexpected spaces around keyword / parameter equals Line 75:47: E251 unexpected spaces around keyword / parameter equals Line 75:68: E231 missing whitespace after ',' Line 76:1: W293 blank line contains whitespace Line 93:1: W293 blank line contains whitespace Line 98:24: E127 continuation line over-indented for visual indent Line 100:23: E127 continuation line over-indented for visual indent Line 103:23: E127 continuation line over-indented for visual indent Line 105:23: E127 continuation line over-indented for visual indent Line 107:19: E127 continuation line over-indented for visual indent Line 115:1: W293 blank line contains whitespace Line 116:59: E225 missing whitespace around operator Line 120:1: E302 expected 2 blank lines, found 1
d3ploy/solver.py
Line 84:80: E501 line too long (82 > 79 characters)
d3ploy/supply_driven_deployment_inst.py
Line 57:80: E501 line too long (84 > 79 characters) Line 138:80: E501 line too long (86 > 79 characters) Line 145:80: E501 line too long (94 > 79 characters) Line 149:80: E501 line too long (85 > 79 characters) Line 158:80: E501 line too long (83 > 79 characters) Line 159:80: E501 line too long (80 > 79 characters) Line 164:80: E501 line too long (83 > 79 characters) Line 165:80: E501 line too long (80 > 79 characters) Line 186:80: E501 line too long (108 > 79 characters) Line 187:80: E501 line too long (86 > 79 characters) Line 198:80: E501 line too long (83 > 79 characters) Line 214:80: E501 line too long (90 > 79 characters) Line 240:80: E501 line too long (86 > 79 characters) Line 242:80: E501 line too long (84 > 79 characters) Line 243:80: E501 line too long (81 > 79 characters) Line 244:80: E501 line too long (82 > 79 characters) Line 245:80: E501 line too long (86 > 79 characters) Line 246:80: E501 line too long (81 > 79 characters) Line 249:80: E501 line too long (86 > 79 characters) Line 258:80: E501 line too long (82 > 79 characters) Line 260:80: E501 line too long (82 > 79 characters) Line 262:80: E501 line too long (82 > 79 characters) Line 263:80: E501 line too long (82 > 79 characters) Line 267:80: E501 line too long (82 > 79 characters)
d3ploy/tester.py
Line 82:20: W291 trailing whitespace Line 96:69: W291 trailing whitespace Line 97:45: W291 trailing whitespace Line 109:22: W291 trailing whitespace Line 111:10: W291 trailing whitespace Line 149:1: E303 too many blank lines (3) Line 250:10: W291 trailing whitespace Line 252:24: W291 trailing whitespace Line 281:21: E231 missing whitespace after ',' Line 281:33: E231 missing whitespace after ',' Line 281:45: E231 missing whitespace after ',' Line 281:52: E231 missing whitespace after ',' Line 283:48: E231 missing whitespace after ',' Line 284:19: W291 trailing whitespace Line 291:80: E501 line too long (98 > 79 characters) Line 295:1: E302 expected 2 blank lines, found 1 Line 302:80: E501 line too long (109 > 79 characters) Line 302:93: E225 missing whitespace around operator Line 306:80: E501 line too long (104 > 79 characters) Line 307:63: E225 missing whitespace around operator Line 309:9: E722 do not use bare 'except' Line 311:80: E501 line too long (83 > 79 characters) Line 314:1: E302 expected 2 blank lines, found 1 Line 325:1: W391 blank line at end of file
d3ploy/timeseries_inst.py
Line 33:12: E251 unexpected spaces around keyword / parameter equals Line 33:14: E251 unexpected spaces around keyword / parameter equals Line 33:70: W291 trailing whitespace Line 35:16: E251 unexpected spaces around keyword / parameter equals Line 35:18: E251 unexpected spaces around keyword / parameter equals Line 35:71: W291 trailing whitespace Line 37:14: E251 unexpected spaces around keyword / parameter equals Line 37:16: E251 unexpected spaces around keyword / parameter equals Line 37:35: E231 missing whitespace after ',' Line 37:46: E231 missing whitespace after ',' Line 38:16: E251 unexpected spaces around keyword / parameter equals Line 38:18: E251 unexpected spaces around keyword / parameter equals Line 38:45: W291 trailing whitespace Line 42:12: E251 unexpected spaces around keyword / parameter equals Line 42:14: E251 unexpected spaces around keyword / parameter equals Line 42:70: W291 trailing whitespace Line 44:16: E251 unexpected spaces around keyword / parameter equals Line 44:18: E251 unexpected spaces around keyword / parameter equals Line 44:63: W291 trailing whitespace Line 46:14: E251 unexpected spaces around keyword / parameter equals Line 46:16: E251 unexpected spaces around keyword / parameter equals Line 46:37: E231 missing whitespace after ',' Line 46:48: E231 missing whitespace after ',' Line 47:16: E251 unexpected spaces around keyword / parameter equals Line 47:18: E251 unexpected spaces around keyword / parameter equals Line 47:44: W291 trailing whitespace Line 51:12: E251 unexpected spaces around keyword / parameter equals Line 51:14: E251 unexpected spaces around keyword / parameter equals Line 51:70: W291 trailing whitespace Line 53:16: E251 unexpected spaces around keyword / parameter equals Line 53:18: E251 unexpected spaces around keyword / parameter equals Line 53:64: W291 trailing whitespace Line 55:14: E251 unexpected spaces around keyword / parameter equals Line 55:16: E251 unexpected spaces around keyword / parameter equals Line 55:33: E231 missing whitespace after ',' Line 55:44: E231 missing whitespace after ',' Line 55:53: W291 trailing whitespace Line 56:16: E251 unexpected spaces around keyword / parameter equals Line 56:18: E251 unexpected spaces around keyword / parameter equals Line 56:46: W291 trailing whitespace Line 57:16: E251 unexpected spaces around keyword / parameter equals Line 57:18: E251 unexpected spaces around keyword / parameter equals Line 61:12: E251 unexpected spaces around keyword / parameter equals Line 61:14: E251 unexpected spaces around keyword / parameter equals Line 61:70: W291 trailing whitespace Line 63:16: E251 unexpected spaces around keyword / parameter equals Line 63:18: E251 unexpected spaces around keyword / parameter equals Line 63:75: W291 trailing whitespace Line 65:14: E251 unexpected spaces around keyword / parameter equals Line 65:16: E251 unexpected spaces around keyword / parameter equals Line 65:45: E231 missing whitespace after ',' Line 65:56: E231 missing whitespace after ',' Line 65:77: W291 trailing whitespace Line 66:16: E251 unexpected spaces around keyword / parameter equals Line 66:18: E251 unexpected spaces around keyword / parameter equals Line 66:57: W291 trailing whitespace Line 67:16: E251 unexpected spaces around keyword / parameter equals Line 67:18: E251 unexpected spaces around keyword / parameter equals Line 71:12: E251 unexpected spaces around keyword / parameter equals Line 71:14: E251 unexpected spaces around keyword / parameter equals Line 71:70: W291 trailing whitespace Line 73:16: E251 unexpected spaces around keyword / parameter equals Line 73:18: E251 unexpected spaces around keyword / parameter equals Line 73:70: W291 trailing whitespace Line 75:14: E251 unexpected spaces around keyword / parameter equals Line 75:16: E251 unexpected spaces around keyword / parameter equals Line 75:42: E231 missing whitespace after ',' Line 75:53: E231 missing whitespace after ',' Line 75:71: W291 trailing whitespace Line 76:16: E251 unexpected spaces around keyword / parameter equals Line 76:18: E251 unexpected spaces around keyword / parameter equals Line 76:62: W291 trailing whitespace Line 77:16: E251 unexpected spaces around keyword / parameter equals Line 77:18: E251 unexpected spaces around keyword / parameter equals Line 184:24: E231 missing whitespace after ',' Line 184:40: E231 missing whitespace after ',' Line 184:58: E231 missing whitespace after ',' Line 184:72: E231 missing whitespace after ',' Line 184:80: E501 line too long (122 > 79 characters) Line 184:98: E231 missing whitespace after ',' Line 184:123: W291 trailing whitespace Line 186:28: W291 trailing whitespace Line 187:51: W291 trailing whitespace Line 188:36: W291 trailing whitespace Line 189:40: E231 missing whitespace after ':' Line 191:50: E231 missing whitespace after ':' Line 192:18: W291 trailing whitespace Line 193:50: E231 missing whitespace after ':' Line 195:63: E231 missing whitespace after ':' Line 195:80: E501 line too long (95 > 79 characters) Line 196:18: W291 trailing whitespace Line 197:63: E231 missing whitespace after ':' Line 199:56: E231 missing whitespace after ':' Line 199:80: E501 line too long (85 > 79 characters) Line 200:18: W291 trailing whitespace Line 201:56: E231 missing whitespace after ':' Line 202:49: W291 trailing whitespace Line 204:41: W291 trailing whitespace Line 205:44: W291 trailing whitespace Line 206:48: E231 missing whitespace after ':' Line 213:71: E231 missing whitespace after ',' Line 213:80: E501 line too long (172 > 79 characters) Line 213:94: E231 missing whitespace after ',' Line 213:113: E231 missing whitespace after ',' Line 213:144: E231 missing whitespace after ',' Line 243:80: E501 line too long (83 > 79 characters)
tests/integration_tests/constraint_test.py
Line 2:11: W291 trailing whitespace Line 34:80: E501 line too long (89 > 79 characters) Line 40:80: E501 line too long (88 > 79 characters)
tests/performance_tests/algorithm_performance_tests.py
Line 32:80: E501 line too long (117 > 79 characters) Line 67:9: E122 continuation line missing indentation or outdented Line 70:1: E265 block comment should start with '# ' Line 70:80: E501 line too long (96 > 79 characters) Line 135:23: W291 trailing whitespace Line 136:23: W291 trailing whitespace Line 137:1: W293 blank line contains whitespace Line 138:80: E501 line too long (85 > 79 characters) Line 140:36: E231 missing whitespace after ',' Line 142:47: E231 missing whitespace after ',' Line 142:59: E231 missing whitespace after ',' Line 142:71: E231 missing whitespace after ',' Line 142:78: E231 missing whitespace after ',' Line 142:80: E501 line too long (83 > 79 characters) Line 215:23: W291 trailing whitespace Line 217:23: W291 trailing whitespace Line 222:28: E231 missing whitespace after ',' Line 229:48: E231 missing whitespace after ',' Line 229:60: E231 missing whitespace after ',' Line 229:72: E231 missing whitespace after ',' Line 229:80: E231 missing whitespace after ',' Line 229:80: E501 line too long (85 > 79 characters) Line 230:47: E231 missing whitespace after ',' Line 230:59: E231 missing whitespace after ',' Line 230:71: E231 missing whitespace after ',' Line 230:78: E231 missing whitespace after ',' Line 230:80: E501 line too long (83 > 79 characters) Line 302:23: W291 trailing whitespace Line 304:23: W291 trailing whitespace Line 309:28: E231 missing whitespace after ',' Line 316:48: E231 missing whitespace after ',' Line 316:60: E231 missing whitespace after ',' Line 316:72: E231 missing whitespace after ',' Line 316:80: E231 missing whitespace after ',' Line 316:80: E501 line too long (85 > 79 characters) Line 317:47: E231 missing whitespace after ',' Line 317:59: E231 missing whitespace after ',' Line 317:71: E231 missing whitespace after ',' Line 317:78: E231 missing whitespace after ',' Line 317:80: E501 line too long (83 > 79 characters) Line 388:23: W291 trailing whitespace Line 390:23: W291 trailing whitespace Line 395:28: E231 missing whitespace after ',' Line 399:32: E225 missing whitespace around operator Line 399:47: E225 missing whitespace around operator Line 402:48: E231 missing whitespace after ',' Line 402:60: E231 missing whitespace after ',' Line 402:72: E231 missing whitespace after ',' Line 402:80: E231 missing whitespace after ',' Line 402:80: E501 line too long (85 > 79 characters) Line 403:47: E231 missing whitespace after ',' Line 403:59: E231 missing whitespace after ',' Line 403:71: E231 missing whitespace after ',' Line 403:78: E231 missing whitespace after ',' Line 403:80: E501 line too long (83 > 79 characters) Line 408:1: W391 blank line at end of file
tests/performance_tests/algorithm_performance_tests_backdeployment.py
Line 2:70: W291 trailing whitespace Line 4:12: W291 trailing whitespace Line 7:58: W291 trailing whitespace Line 8:80: E501 line too long (93 > 79 characters) Line 8:94: W291 trailing whitespace Line 9:65: W291 trailing whitespace Line 31:80: E501 line too long (117 > 79 characters) Line 39:1: E266 too many leading '#' for block comment Line 64:80: E501 line too long (82 > 79 characters) Line 74:1: E265 block comment should start with '# ' Line 74:80: E501 line too long (90 > 79 characters) Line 82:4: E122 continuation line missing indentation or outdented Line 84:80: E501 line too long (83 > 79 characters) Line 88:4: E122 continuation line missing indentation or outdented Line 89:80: E501 line too long (84 > 79 characters) Line 92:4: E122 continuation line missing indentation or outdented Line 109:3: E122 continuation line missing indentation or outdented Line 110:3: E122 continuation line missing indentation or outdented Line 111:4: E122 continuation line missing indentation or outdented Line 114:80: E501 line too long (82 > 79 characters) Line 116:4: E122 continuation line missing indentation or outdented Line 121:3: E122 continuation line missing indentation or outdented Line 123:4: E122 continuation line missing indentation or outdented Line 124:4: E122 continuation line missing indentation or outdented Line 152:4: E122 continuation line missing indentation or outdented Line 153:3: E122 continuation line missing indentation or outdented Line 168:23: W291 trailing whitespace Line 170:23: W291 trailing whitespace Line 171:28: W291 trailing whitespace Line 176:28: E231 missing whitespace after ',' Line 178:33: E231 missing whitespace after ',' Line 179:1: W293 blank line contains whitespace Line 180:80: E501 line too long (102 > 79 characters) Line 182:32: E225 missing whitespace around operator Line 182:47: E225 missing whitespace around operator Line 184:32: E225 missing whitespace around operator Line 184:47: E225 missing whitespace around operator Line 186:1: W293 blank line contains whitespace Line 187:48: E231 missing whitespace after ',' Line 187:60: E231 missing whitespace after ',' Line 187:72: E231 missing whitespace after ',' Line 187:80: E231 missing whitespace after ',' Line 187:80: E501 line too long (85 > 79 characters) Line 188:47: E231 missing whitespace after ',' Line 188:59: E231 missing whitespace after ',' Line 188:71: E231 missing whitespace after ',' Line 188:78: E231 missing whitespace after ',' Line 188:80: E501 line too long (83 > 79 characters) Line 189:52: E231 missing whitespace after ',' Line 189:64: E231 missing whitespace after ',' Line 189:76: E231 missing whitespace after ',' Line 189:80: E501 line too long (94 > 79 characters) Line 189:88: E231 missing whitespace after ',' Line 190:1: W293 blank line contains whitespace Line 195:1: E265 block comment should start with '# ' Line 195:80: E501 line too long (90 > 79 characters) Line 196:80: E501 line too long (84 > 79 characters) Line 203:4: E122 continuation line missing indentation or outdented Line 205:80: E501 line too long (83 > 79 characters) Line 209:4: E122 continuation line missing indentation or outdented Line 210:80: E501 line too long (88 > 79 characters) Line 213:4: E122 continuation line missing indentation or outdented Line 225:4: E122 continuation line missing indentation or outdented Line 242:3: E122 continuation line missing indentation or outdented Line 244:4: E122 continuation line missing indentation or outdented Line 245:4: E122 continuation line missing indentation or outdented Line 265:80: E501 line too long (83 > 79 characters) Line 273:4: E122 continuation line missing indentation or outdented Line 274:3: E122 continuation line missing indentation or outdented Line 288:23: W291 trailing whitespace Line 290:23: W291 trailing whitespace Line 291:28: W291 trailing whitespace Line 292:32: W291 trailing whitespace Line 297:28: E231 missing whitespace after ',' Line 299:33: E231 missing whitespace after ',' Line 301:5: E122 continuation line missing indentation or outdented Line 301:33: E231 missing whitespace after ',' Line 303:80: E501 line too long (102 > 79 characters) Line 305:32: E225 missing whitespace around operator Line 305:47: E225 missing whitespace around operator Line 307:32: E225 missing whitespace around operator Line 307:47: E225 missing whitespace around operator Line 309:32: E225 missing whitespace around operator Line 309:47: E225 missing whitespace around operator Line 310:80: E501 line too long (85 > 79 characters) Line 312:48: E231 missing whitespace after ',' Line 312:60: E231 missing whitespace after ',' Line 312:72: E231 missing whitespace after ',' Line 312:80: E231 missing whitespace after ',' Line 312:80: E501 line too long (85 > 79 characters) Line 313:47: E231 missing whitespace after ',' Line 313:59: E231 missing whitespace after ',' Line 313:71: E231 missing whitespace after ',' Line 313:78: E231 missing whitespace after ',' Line 313:80: E501 line too long (83 > 79 characters) Line 314:52: E231 missing whitespace after ',' Line 314:64: E231 missing whitespace after ',' Line 314:76: E231 missing whitespace after ',' Line 314:80: E501 line too long (94 > 79 characters) Line 314:88: E231 missing whitespace after ',' Line 315:56: E231 missing whitespace after ',' Line 315:68: E231 missing whitespace after ',' Line 315:80: E231 missing whitespace after ',' Line 315:80: E501 line too long (102 > 79 characters) Line 315:96: E231 missing whitespace after ','
tests/performance_tests/algorithm_performance_tests_closedfuelcycle.py
Line 2:70: W291 trailing whitespace Line 4:12: W291 trailing whitespace Line 7:58: W291 trailing whitespace Line 8:80: E501 line too long (93 > 79 characters) Line 8:94: W291 trailing whitespace Line 9:65: W291 trailing whitespace Line 31:80: E501 line too long (117 > 79 characters) Line 39:1: E266 too many leading '#' for block comment Line 43:1: E265 block comment should start with '# ' Line 43:80: E501 line too long (90 > 79 characters) Line 49:2: E122 continuation line missing indentation or outdented Line 91:80: E501 line too long (90 > 79 characters) Line 95:80: E501 line too long (89 > 79 characters) Line 183:80: E501 line too long (90 > 79 characters) Line 187:80: E501 line too long (89 > 79 characters) Line 262:1: E122 continuation line missing indentation or outdented Line 274:23: W291 trailing whitespace Line 280:36: E231 missing whitespace after ',' Line 281:1: W293 blank line contains whitespace Line 282:80: E501 line too long (92 > 79 characters) Line 283:80: E501 line too long (85 > 79 characters) Line 285:80: E501 line too long (102 > 79 characters) Line 286:80: E501 line too long (103 > 79 characters) Line 287:32: E225 missing whitespace around operator Line 287:47: E225 missing whitespace around operator Line 288:80: E501 line too long (96 > 79 characters) Line 290:1: W293 blank line contains whitespace Line 291:51: E231 missing whitespace after ',' Line 291:63: E231 missing whitespace after ',' Line 291:75: E231 missing whitespace after ',' Line 291:80: E501 line too long (88 > 79 characters) Line 291:83: E231 missing whitespace after ',' Line 292:58: E231 missing whitespace after ',' Line 292:70: E231 missing whitespace after ',' Line 292:80: E501 line too long (102 > 79 characters) Line 292:82: E231 missing whitespace after ',' Line 292:97: E231 missing whitespace after ',' Line 293:1: W293 blank line contains whitespace
tests/performance_tests/algorithm_performance_tests_transitionscenario.py
Line 2:70: W291 trailing whitespace Line 4:12: W291 trailing whitespace Line 7:58: W291 trailing whitespace Line 8:80: E501 line too long (93 > 79 characters) Line 8:94: W291 trailing whitespace Line 9:65: W291 trailing whitespace Line 31:80: E501 line too long (93 > 79 characters) Line 39:1: E265 block comment should start with '# ' Line 39:80: E501 line too long (101 > 79 characters) Line 46:19: W291 trailing whitespace Line 61:37: E203 whitespace before ':' Line 72:80: E501 line too long (87 > 79 characters) Line 78:80: E501 line too long (85 > 79 characters) Line 81:25: E128 continuation line under-indented for visual indent Line 83:80: E501 line too long (80 > 79 characters) Line 90:25: E128 continuation line under-indented for visual indent Line 92:80: E501 line too long (80 > 79 characters)
Hello @gwenchee! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
d3ploy/plotter.py:d3ploy/solver.py:d3ploy/supply_driven_deployment_inst.py:d3ploy/tester.py:d3ploy/timeseries_inst.py:tests/integration_tests/constraint_test.py:tests/performance_tests/algorithm_performance_tests.py:tests/performance_tests/algorithm_performance_tests_backdeployment.py:tests/performance_tests/algorithm_performance_tests_closedfuelcycle.py:tests/performance_tests/algorithm_performance_tests_transitionscenario.py: