Closed FlanFlanagan closed 5 years ago
Hello @FlanFlanagan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
d3ploy/demand_driven_deployment_inst.py
:Line 253:80: E501 line too long (83 > 79 characters)
d3ploy/plotter.py
:Line 51:80: E501 line too long (80 > 79 characters) Line 93:80: E501 line too long (80 > 79 characters) Line 138:80: E501 line too long (84 > 79 characters) Line 151:80: E501 line too long (81 > 79 characters)
d3ploy/solver.py
:Line 83:80: E501 line too long (82 > 79 characters)
d3ploy/supply_driven_deployment_inst.py
:Line 96:80: E501 line too long (84 > 79 characters) Line 230:80: E501 line too long (108 > 79 characters) Line 231:80: E501 line too long (86 > 79 characters) Line 242:80: E501 line too long (83 > 79 characters) Line 258:80: E501 line too long (90 > 79 characters) Line 284:80: E501 line too long (86 > 79 characters) Line 286:80: E501 line too long (84 > 79 characters) Line 287:80: E501 line too long (81 > 79 characters) Line 288:80: E501 line too long (82 > 79 characters) Line 289:80: E501 line too long (86 > 79 characters) Line 290:80: E501 line too long (81 > 79 characters) Line 302:80: E501 line too long (82 > 79 characters) Line 304:80: E501 line too long (82 > 79 characters) Line 306:80: E501 line too long (82 > 79 characters) Line 307:80: E501 line too long (82 > 79 characters)
d3ploy/tester.py
:Line 301:9: E265 block comment should start with '# ' Line 302:9: E265 block comment should start with '# ' Line 305:5: E265 block comment should start with '# ' Line 306:5: E265 block comment should start with '# ' Line 308:80: E501 line too long (91 > 79 characters) Line 327:80: E501 line too long (84 > 79 characters)
tests/integration_tests/back_deployment_test.py
:Line 35:80: E501 line too long (84 > 79 characters)
tests/integration_tests/constraint_test.py
:Line 2:11: W291 trailing whitespace Line 34:80: E501 line too long (89 > 79 characters) Line 40:80: E501 line too long (88 > 79 characters)
Line 36:80: E501 line too long (105 > 79 characters) Line 89:80: E501 line too long (80 > 79 characters) Line 96:80: E501 line too long (81 > 79 characters)
tests/integration_tests/tech_pref_test.py
:Line 45:80: E501 line too long (84 > 79 characters)
Line 8:80: E501 line too long (93 > 79 characters) Line 53:80: E501 line too long (105 > 79 characters) Line 61:80: E501 line too long (94 > 79 characters) Line 66:80: E501 line too long (88 > 79 characters) Line 71:1: E265 block comment should start with '# ' Line 169:1: E265 block comment should start with '# ' Line 294:1: E265 block comment should start with '# ' Line 418:1: E265 block comment should start with '# '
Line 8:80: E501 line too long (93 > 79 characters) Line 40:1: E266 too many leading '#' for block comment Line 53:80: E501 line too long (102 > 79 characters) Line 65:80: E501 line too long (94 > 79 characters) Line 70:80: E501 line too long (88 > 79 characters) Line 75:1: E265 block comment should start with '# ' Line 85:80: E501 line too long (94 > 79 characters) Line 90:80: E501 line too long (92 > 79 characters) Line 115:80: E501 line too long (90 > 79 characters) Line 120:80: E501 line too long (84 > 79 characters) Line 257:1: E265 block comment should start with '# ' Line 268:80: E501 line too long (94 > 79 characters) Line 273:80: E501 line too long (96 > 79 characters)
Line 8:80: E501 line too long (93 > 79 characters) Line 40:1: E266 too many leading '#' for block comment Line 44:1: E265 block comment should start with '# ' Line 60:80: E501 line too long (106 > 79 characters) Line 67:80: E501 line too long (82 > 79 characters) Line 92:80: E501 line too long (121 > 79 characters) Line 96:80: E501 line too long (120 > 79 characters) Line 113:80: E501 line too long (95 > 79 characters) Line 114:80: E501 line too long (94 > 79 characters) Line 117:80: E501 line too long (90 > 79 characters) Line 122:80: E501 line too long (94 > 79 characters) Line 123:80: E501 line too long (93 > 79 characters) Line 126:80: E501 line too long (90 > 79 characters) Line 184:80: E501 line too long (121 > 79 characters) Line 188:80: E501 line too long (120 > 79 characters) Line 200:80: E501 line too long (92 > 79 characters) Line 211:80: E501 line too long (94 > 79 characters) Line 216:80: E501 line too long (94 > 79 characters) Line 228:80: E501 line too long (84 > 79 characters) Line 229:80: E501 line too long (84 > 79 characters) Line 230:80: E501 line too long (88 > 79 characters) Line 235:80: E501 line too long (84 > 79 characters) Line 236:80: E501 line too long (84 > 79 characters) Line 237:80: E501 line too long (81 > 79 characters) Line 242:80: E501 line too long (80 > 79 characters) Line 248:80: E501 line too long (99 > 79 characters) Line 253:80: E501 line too long (89 > 79 characters) Line 271:80: E501 line too long (97 > 79 characters) Line 272:80: E501 line too long (90 > 79 characters) Line 273:80: E501 line too long (96 > 79 characters) Line 278:80: E501 line too long (88 > 79 characters) Line 279:80: E501 line too long (81 > 79 characters) Line 280:80: E501 line too long (87 > 79 characters)
Line 8:80: E501 line too long (93 > 79 characters) Line 40:1: E265 block comment should start with '# '
CI is broken.
If this is passing tests on your end could you merge it in @gwenchee ?
Proof it passes
I will fix all pep 8 issues then merge
as per @gwenchee 's request.