search

arfc / d3ploy

A collection of Cyclus manager archetypes for demand driven deployment
BSD 3-Clause "New" or "Revised" License
4 stars 11 forks source link

Extra supply #232

Closed FlanFlanagan closed 5 years ago

FlanFlanagan commented 5 years ago

This is the tackle issue #224 by artificially increasing demand invisibly to users. This ensures a "supply buffer".

pep8speaks commented 5 years ago

Hello @FlanFlanagan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 176:1: E302 expected 2 blank lines, found 1 Line 178:1: W293 blank line contains whitespace Line 178:1: W391 blank line at end of file

Comment last updated at 2019-04-19 21:46:15 UTC
FlanFlanagan commented 5 years ago

Change to per commod with a decimal value

gwenchee commented 5 years ago

Looks good to me. Could you add the variable into the README before we merge? @FlanFlanagan

gwenchee commented 5 years ago

I pulled this branch into my computer and fixed all the issues that I commented on. Would you prefer if I PR into your branch or make a new PR into arfc/d3ploy's master branch @FlanFlanagan

katyhuff commented 5 years ago

@FlanFlanagan it looks like these commits have been incorporated into #233 and improvements are being made there. Closing this issue.