search

arfc / d3ploy

A collection of Cyclus manager archetypes for demand driven deployment
BSD 3-Clause "New" or "Revised" License
4 stars 11 forks source link

Transition scenarios #259

Closed gwenchee closed 5 years ago

gwenchee commented 5 years ago

This PR contains a performance test that gives a basic transition scenario from ten initial reactors to a fleet of new reactors where there is a constant, growing or sinusoidal power demand. There are source, reactor and sink facilities in this simulation. The source and reactor facilities are deployed using DemandDrivenDeploymentInst and the sink facilities are deployed using SupplyDrivenDeploymentInst.

In tests/performance_tests, by running python algorithm_performance_tests_transitions.py [transitiontype], the plots shown below will be generated, including the plots for other commodities (fuel, spentfuel)

Examples of the power commodity plots for each type of scenario: constanttransition-power growingtransition-power sinetransition-power

pep8speaks commented 5 years ago

Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-05 19:50:14 UTC
FlanFlanagan commented 5 years ago

These figures look really nice Gwen.

The changes are huge though. Is it mostly PEP8 stuff?

gwenchee commented 5 years ago

All the changes in demand_driven_deployment_inst.py are pep 8 issues. The xml files and algorithm_performance_tests_transitions.py are new additions that generate these plots. And I made a few changes in plotter.py to enhance the plots.

FlanFlanagan commented 5 years ago

Excellent, I'll review those then.

gwenchee commented 5 years ago

@katyhuff the comments you made about the commas that were added were added by an autopep8 software.

gwenchee commented 5 years ago

Awesome! It passes the CI! Time to merge? @FlanFlanagan @robfairh @katyhuff @sonatav2