Update to new MOOSE JSON package

arfc / moltres

Repository for Moltres, a code for simulating Molten Salt Reactors

GNU Lesser General Public License v2.1

66 stars 41 forks source link

Update to new MOOSE JSON package #125

Closed aeslaughter closed 3 years ago

aeslaughter commented 3 years ago

Updates for coming changes to MOOSE. This will fail until those changes are merged, see MOOSE#15719

(refs MOOSE#11323)

aeslaughter commented 3 years ago

@katyhuff I think my original comment was unclear. With this being merged moltres no longer will compile, until MOOSE#15719 is merged. I am hoping that happens soon, but can't be for sure. You might want to revert this merge for the time being. Sorry for the confusion.

katyhuff commented 3 years ago

Ah! Thanks!! Your comment was clear -- that was how I understood it originally. But, then I noticed that in the CI, Moltres was the only app failing the tests and doubted myself! Reverting. Now I have something else about those failing tests to figure out... (ETA: I see now that it's ok on main. nvm)

katyhuff commented 3 years ago

I'll keep an eye on MOOSE#15719 and will revert the revert at that time. Sorry!