arfc / moltres

Repository for Moltres, a code for simulating Molten Salt Reactors
GNU Lesser General Public License v2.1
66 stars 41 forks source link

Update deprecated code #156

Closed robfairh closed 3 years ago

robfairh commented 3 years ago

Fixes #150.

Running ./run_tests -j4 --error-deprecated yields the following output:

pre.pre_loop_ins ................................................................................ [HEAVY] SKIP
pre.pre_loop .................................................................................... [HEAVY] SKIP
twod_axi_coupled.coupled ........................................................................ [HEAVY] SKIP
pre.pre ................................................................................................... OK
temp.temp ................................................................................................. OK
decay_heat.decay_heat ..................................................................................... OK
laminar_flow.boussinesqSquare ............................................................................. OK
bcs.coupled_bc ............................................................................................ OK
kernels.scalar_advection_art_diff ......................................................................... OK
postprocessors.side_weighted_integral ..................................................................... OK
nts.nts ................................................................................................... OK
problems/2017_annals_pub_msre_compare.4group ..................................................... SYNTAX PASS
postprocessors.side_weighted_integral_RZ .................................................................. OK
problems/2017_annals_pub_msre_compare.4group_eigen ............................................... SYNTAX PASS
problems/2017_annals_pub_msre_compare.2group ..................................................... SYNTAX PASS
problems/2017_annals_pub_msre_compare.2group_eigen ............................................... SYNTAX PASS
nts.nts_no_action ......................................................................................... OK
diracHX.dirachx ........................................................................................... OK
problems/2017_annals_pub_msre_compare.auto_diff_rho .............................................. SYNTAX PASS
problems/033117_nts_temp_pre_parsed_mat.syntax ....................................................... RUNNING
problems/033117_nts_temp_pre_parsed_mat.syntax ........................................ [FINISHED] SYNTAX PASS
--------------------------------------------------------------------------------------------------------------
Ran 17 tests in 131.0 seconds.
17 passed, 3 skipped, 0 pending, 0 failed

Some of the files where I changed D_name by diffusivity are not included in the tests, but I updated them anyway to be consistent.

robfairh commented 3 years ago

I have also run ./run_tests -j4 --heavy and the output is the following:

pre.pre_loop ......................................................................................... RUNNING
twod_axi_coupled.coupled ............................................................................. RUNNING
pre.pre_loop ................................................................................... [FINISHED] OK
pre.pre_loop_ins ..................................................................................... RUNNING
twod_axi_coupled.coupled ....................................................................... [FINISHED] OK
pre.pre_loop_ins ............................................................................... [FINISHED] OK
--------------------------------------------------------------------------------------------------------------
Ran 3 tests in 186.7 seconds.
3 passed, 0 skipped, 0 pending, 0 failed

~~I guess this partially solves #152. Maybe removing these lines would finish solving it? @smpark7 thoughts?~~

Maybe I should make sure which version of moose I actually have on my machine.

Yeah, I have:

moose-libmesh             2020.11.04              build_0    https://mooseframework.org/conda/moose
moose-tools               2020.04.13       py37h734910c_0    https://mooseframework.org/conda/moose
robfairh commented 3 years ago

Well, it seems like the tests pass on CIVET now. The error comes on the unit tests.

robfairh commented 3 years ago

@smpark7 Done!