Closed gwenchee closed 2 years ago
Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
python/moltres_xs.py
:Line 70:80: E501 line too long (85 > 79 characters) Line 73:80: E501 line too long (88 > 79 characters) Line 115:80: E501 line too long (84 > 79 characters) Line 141:80: E501 line too long (84 > 79 characters) Line 142:80: E501 line too long (80 > 79 characters) Line 143:80: E501 line too long (82 > 79 characters) Line 145:80: E501 line too long (80 > 79 characters) Line 200:80: E501 line too long (86 > 79 characters) Line 203:80: E501 line too long (81 > 79 characters) Line 211:80: E501 line too long (80 > 79 characters) Line 216:80: E501 line too long (81 > 79 characters) Line 217:80: E501 line too long (81 > 79 characters) Line 220:80: E501 line too long (82 > 79 characters) Line 249:80: E501 line too long (84 > 79 characters) Line 250:80: E501 line too long (81 > 79 characters) Line 505:80: E501 line too long (83 > 79 characters)
python/test/godiva/godiva_openmc_1200.py
:Line 6:1: E402 module level import not at top of file Line 25:1: E266 too many leading '#' for block comment Line 25:17: W291 trailing whitespace Line 31:30: E231 missing whitespace after ',' Line 31:32: E231 missing whitespace after ',' Line 43:2: W292 no newline at end of file
python/test/godiva/godiva_openmc_900.py
:Line 6:1: E402 module level import not at top of file Line 25:1: E266 too many leading '#' for block comment Line 25:17: W291 trailing whitespace Line 31:30: E231 missing whitespace after ',' Line 31:32: E231 missing whitespace after ',' Line 43:2: W292 no newline at end of file
Oh no why is everything broken?!
@munkm It seems that Gwen's Moltres developer status has also changed somehow because the tests need activation like my other PR. The last PR she made in #112 didn't require activation.
Also, should we require the Doxygen/GitHub Pages action to update gh-pages in pull requests? I made it so, but I now realize that it may be unnecessary or even detrimental to our documentation if we get a poor quality/malicious PR.
Also, I'm not sure why the action failed. The error msg says that the github-actions bot didn't have permission to push commits into gh-pages. Perhaps this only happens when the action is triggered by PRs. If so, we can ignore this if we're gonna remove the action trigger on PR.
oops i made a mistake. going to make a new PR
For this PR, I ran a pep8 linter on
moltres_xs.py
.