arfc / moltres

Repository for Moltres, a code for simulating Molten Salt Reactors
GNU Lesser General Public License v2.1
66 stars 41 forks source link

Pep8 linter on moltres_xs.py #170

Closed gwenchee closed 2 years ago

gwenchee commented 2 years ago

For this PR, I ran a pep8 linter on moltres_xs.py.

pep8speaks commented 2 years ago

Hello @gwenchee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 70:80: E501 line too long (85 > 79 characters) Line 73:80: E501 line too long (88 > 79 characters) Line 115:80: E501 line too long (84 > 79 characters) Line 141:80: E501 line too long (84 > 79 characters) Line 142:80: E501 line too long (80 > 79 characters) Line 143:80: E501 line too long (82 > 79 characters) Line 145:80: E501 line too long (80 > 79 characters) Line 200:80: E501 line too long (86 > 79 characters) Line 203:80: E501 line too long (81 > 79 characters) Line 211:80: E501 line too long (80 > 79 characters) Line 216:80: E501 line too long (81 > 79 characters) Line 217:80: E501 line too long (81 > 79 characters) Line 220:80: E501 line too long (82 > 79 characters) Line 249:80: E501 line too long (84 > 79 characters) Line 250:80: E501 line too long (81 > 79 characters) Line 505:80: E501 line too long (83 > 79 characters)

Line 6:1: E402 module level import not at top of file Line 25:1: E266 too many leading '#' for block comment Line 25:17: W291 trailing whitespace Line 31:30: E231 missing whitespace after ',' Line 31:32: E231 missing whitespace after ',' Line 43:2: W292 no newline at end of file

Line 6:1: E402 module level import not at top of file Line 25:1: E266 too many leading '#' for block comment Line 25:17: W291 trailing whitespace Line 31:30: E231 missing whitespace after ',' Line 31:32: E231 missing whitespace after ',' Line 43:2: W292 no newline at end of file

Comment last updated at 2021-10-11 23:34:06 UTC
smpark7 commented 2 years ago

Oh no why is everything broken?!

smpark7 commented 2 years ago

@munkm It seems that Gwen's Moltres developer status has also changed somehow because the tests need activation like my other PR. The last PR she made in #112 didn't require activation.

Also, should we require the Doxygen/GitHub Pages action to update gh-pages in pull requests? I made it so, but I now realize that it may be unnecessary or even detrimental to our documentation if we get a poor quality/malicious PR.

Also, I'm not sure why the action failed. The error msg says that the github-actions bot didn't have permission to push commits into gh-pages. Perhaps this only happens when the action is triggered by PRs. If so, we can ignore this if we're gonna remove the action trigger on PR.

gwenchee commented 2 years ago

oops i made a mistake. going to make a new PR