search

arfc / moltres

Repository for Moltres, a code for simulating Molten Salt Reactors
GNU Lesser General Public License v2.1
66 stars 41 forks source link

Add default value for vector type input parameters #251

Closed MengnanLi91 closed 1 year ago

MengnanLi91 commented 1 year ago

Bug Description

Refer to the issue #24455, a fix is introduced to MOOSE to properly report error when no default value is provided for vector type input parameter. This new fix in MOOSE cause several tests failed in Moltres which don't provide default value for vector parameter.

Impact

This patch is made to fix the failed Moltres tests due to the new changes in MOOSE

smpark7 commented 1 year ago

Hi @MengnanLi91 I'm not sure why the CI failed. I don't see anything wrong with what you did to TransientFissionHeatSource. Can you help me take a look? Thanks

smpark7 commented 1 year ago

I think it's because our MOOSE submodule is from Aug 17; it doesn't include idaholab/moose#25341 which allows {} to specify empty vector defaults.

MengnanLi91 commented 1 year ago

@smpark7 I just push a MOOSE submodule update. Could you help me activate the test?

smpark7 commented 1 year ago

Thanks @MengnanLi91. I'll merge once the tests pass.