search

arfc / msbr-reproc

holds a paper describing an MSBR online reprocessing demonstration.
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Comments Teddy #20

Closed jbae11 closed 6 years ago

jbae11 commented 6 years ago

Great Job Andrei! msbr-reproc.pdf

andrewryh commented 6 years ago

@jbae11 Thanks for edits, I've implemented most of them. Small comment: I cite in this paperSaltProc version 0.1.0 which doesn't have two-fluid support, etc. So, it will be in next papers.

jbae11 commented 6 years ago

@andrewryh sounds good !

jbae11 commented 6 years ago

@andrewryh Can you close this once this is reflected in your paper? thanks!

katyhuff commented 6 years ago

@andrewryh : As you make edits in response to comments, it's best to make a single pull request addressing the comments in the issue, mention the issue, and request a review of that PR by the person who opened the issue. Then, when the PR is merged, you can close this issue and it's clear to everyone involved what's been accomplished.