search

arfc / msbr-reproc

holds a paper describing an MSBR online reprocessing demonstration.
BSD 3-Clause "New" or "Revised" License
6 stars 4 forks source link

Comments - Ansh #21

Closed anshchaube closed 6 years ago

anshchaube commented 6 years ago

msbr-reproc-edited.pdf

Due to @andrewryh 's request for speeding up the review process, @gtw2 and I are reviewing the first half. Refer to @smpark7 and @gwenchee 's issues for comments on the second half.

andrewryh commented 6 years ago

@jbae11 There are some edits in your part. I have implemented it, just check it out.

andrewryh commented 6 years ago

Thanks for the feedback, very helpful. I agree with most of them, fixed. There is some conceptual misunderstanding, we'll discuss it in person soon

katyhuff commented 6 years ago

@andrewryh : As you make edits in response to comments, it's best to make a single pull request addressing the comments in the issue, mention the issue, and request a review of that PR by the person who opened the issue. Then, when the PR is merged, you can close this issue and it's clear to everyone involved what's been accomplished.

andrewryh commented 6 years ago

I got this. But this far I made it wrong way: so, I have single PR for all guys comments... Sorry

katyhuff commented 6 years ago

no worries! 1 combined PR is totally fine! I just wanted to make sure these edits make it into the main fork.

On Thu, Sep 6, 2018 at 7:51 AM Andrei Rykhlevskii notifications@github.com wrote:

I got this. But this far I made it wrong way: so, I have single PR for all guys comments... Sorry

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arfc/msbr-reproc/issues/21#issuecomment-419081389, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYCq2e-zKU-yrlXP-kH2sYkicxncyu4ks5uYRpkgaJpZM4WURmd .

-- http://katyhuff.github.com