search

arfc / msr-neutronics

To hold development code, milestones, and developments for msr neutronics.
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

MSFR directory revamp #45

Closed smpark7 closed 6 years ago

smpark7 commented 6 years ago

Deleted all old files in MSFR, especially the huge image files which made repo unnecessarily big.

Reorganised files in a neater format.

There is no need to check my files. Review request is just to ensure I didn't accidentally edit others' files.

pep8speaks commented 6 years ago

Hello @smpark7! Thanks for submitting the PR.

Line 2:80: E501 line too long (98 > 79 characters) Line 3:80: E501 line too long (98 > 79 characters) Line 12:80: E501 line too long (105 > 79 characters) Line 63:80: E501 line too long (82 > 79 characters) Line 68:80: E501 line too long (100 > 79 characters) Line 70:80: E501 line too long (87 > 79 characters) Line 71:80: E501 line too long (83 > 79 characters) Line 75:80: E501 line too long (87 > 79 characters) Line 76:80: E501 line too long (87 > 79 characters) Line 77:80: E501 line too long (88 > 79 characters) Line 85:80: E501 line too long (115 > 79 characters) Line 86:80: E501 line too long (83 > 79 characters) Line 87:80: E501 line too long (99 > 79 characters) Line 88:80: E501 line too long (87 > 79 characters) Line 92:80: E501 line too long (99 > 79 characters) Line 93:80: E501 line too long (91 > 79 characters) Line 94:80: E501 line too long (92 > 79 characters) Line 109:80: E501 line too long (109 > 79 characters) Line 115:80: E501 line too long (80 > 79 characters) Line 117:80: E501 line too long (87 > 79 characters) Line 119:80: E501 line too long (81 > 79 characters) Line 121:80: E501 line too long (83 > 79 characters)

Line 1:21: E231 missing whitespace after ',' Line 9:1: E265 block comment should start with '# ' Line 10:1: E402 module level import not at top of file Line 12:1: E302 expected 2 blank lines, found 1 Line 70:13: E741 ambiguous variable name 'l' Line 76:9: E741 ambiguous variable name 'l' Line 87:9: E741 ambiguous variable name 'l' Line 96:13: E741 ambiguous variable name 'l' Line 116:17: E741 ambiguous variable name 'l' Line 169:1: E305 expected 2 blank lines after class or function definition, found 1 Line 172:1: E402 module level import not at top of file Line 173:1: E402 module level import not at top of file Line 174:1: E402 module level import not at top of file Line 175:1: E402 module level import not at top of file Line 179:80: E501 line too long (93 > 79 characters) Line 181:11: E201 whitespace after '(' Line 181:15: E202 whitespace before ')' Line 184:1: E302 expected 2 blank lines, found 1 Line 184:80: E501 line too long (105 > 79 characters) Line 194:1: W293 blank line contains whitespace Line 196:5: E303 too many blank lines (2) Line 197:28: E231 missing whitespace after ',' Line 197:35: E231 missing whitespace after ',' Line 197:44: E231 missing whitespace after ',' Line 197:55: E231 missing whitespace after ',' Line 197:63: E231 missing whitespace after ',' Line 197:69: E231 missing whitespace after ',' Line 197:75: E231 missing whitespace after ',' Line 197:80: E501 line too long (111 > 79 characters) Line 197:82: E231 missing whitespace after ',' Line 197:90: E231 missing whitespace after ',' Line 197:97: E231 missing whitespace after ',' Line 197:105: E231 missing whitespace after ',' Line 198:12: E221 multiple spaces before operator Line 216:1: W293 blank line contains whitespace Line 222:1: W293 blank line contains whitespace Line 235:80: E501 line too long (94 > 79 characters) Line 238:9: E303 too many blank lines (2) Line 241:80: E501 line too long (96 > 79 characters) Line 242:80: E501 line too long (104 > 79 characters) Line 243:80: E501 line too long (80 > 79 characters) Line 246:80: E501 line too long (114 > 79 characters) Line 246:96: E231 missing whitespace after ',' Line 251:80: E501 line too long (96 > 79 characters) Line 256:80: E501 line too long (111 > 79 characters) Line 257:80: E501 line too long (112 > 79 characters) Line 258:80: E501 line too long (80 > 79 characters) Line 261:80: E501 line too long (114 > 79 characters) Line 261:96: E231 missing whitespace after ',' Line 265:16: W292 no newline at end of file

smpark7 commented 6 years ago

I just realised there are 98 "file changes". I have checked that all changes are in my own MSFR directory. I think it should be okay to merge.

@katyhuff

smpark7 commented 6 years ago

@andrewryh Thanks for reviewing!