search

arfc / predicting-the-past

The predicting the past project.
BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

80 -> 800k error #18

Closed katyhuff closed 7 years ago

katyhuff commented 7 years ago

The bug we looked at the other day, where there was an order of magnitude error in the power generation graph.... it should be fixed with a (single, atomic) pull request. Use a separate branch, please, so that only this change is present in the PR.

gyutaepark commented 7 years ago

Ooops, I should have done this on the day... I'll do so right away. Thank you

gyutaepark commented 7 years ago

Actually, it seems like the bug was only present on the develop branch. The master branch does not have this issue. I must have accidentally added an extra zero after merging the most recent PR. I'll close this issue now since it wasn't actually an issue for master branch.

gyutaepark commented 7 years ago

Oops, I've now really understood what you've meant. I'll undo that commit with the CF fix and make it into a now PR

gyutaepark commented 7 years ago

The fix is now performed in #20