search

arfc / pride

(P)lan for (R)ap(I)d (DE)carbonization
BSD 3-Clause "New" or "Revised" License
3 stars 7 forks source link

Temoa #109

Closed samgdotson closed 3 years ago

samgdotson commented 3 years ago

This PR:

New temoa models can now be added. Eventually, these first scenarios will be removed from the snakemake once we have a complete model of UIUC that includes transportation, energy storage, and new economies like hydrogen.

pep8speaks commented 3 years ago

Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-12-03 16:32:40 UTC
robfairh commented 3 years ago

I've run one of the cases and I got this warning:

Warning: ('uiuc', 'IMPELC', 2000) has a specified Efficiency, but does not have any existing install base (ExistingCapacity). Warning: ('uiuc', 'ABBOTT', 2020) has a specified Efficiency, but does not have any existing install base (ExistingCapacity). Warning: ('uiuc', 'TURBINE', 2020) has a specified Efficiency, but does not have any existing install base (ExistingCapacity). Warning: ('uiuc', 'NUCLEAR', 2020) has a specified Efficiency, but does not have any existing install base (ExistingCapacity). Warning: ('uiuc', 'UL', 2000) has a specified Efficiency, but does not have any existing install base (ExistingCapacity). Warning: ('uiuc', 'UL', 2020) has a specified Efficiency, but does not have any existing install base (ExistingCapacity). Warning: ('uiuc', 'UH', 2000) has a specified Efficiency, but does not have any existing install base (ExistingCapacity). Warning: ('uiuc', 'UH', 2020) has a specified Efficiency, but does not have any existing install base (ExistingCapacity).

I am still familiarizing myself with TEMOA, how important is this warning?

samgdotson commented 3 years ago

I don't think it's a problem, it still produces results. I'll check if it changes anything.

samgdotson commented 3 years ago

@robfairh 1) The warning doesn't hurt anything. It's just pointing out that I offered an efficiency for some technologies that didn't actually exist in the years specified. 2000 and 2020 are considered "existing" time periods. We didn't build an import system (IMPELC) in 2000 so the technology doesn't "exist". It's a bit weird. 2) I have fixed scenario04 to stop the warnings. If we want to do this for the other scenarios we can (by opening a new issue) but it's not essential.

robfairh commented 3 years ago

Great! I think you have addressed all of @yardasol's comments as well. So I'll merge the PR.