search

arfc / pride

(P)lan for (R)ap(I)d (DE)carbonization
BSD 3-Clause "New" or "Revised" License
3 stars 7 forks source link

UIUC Transportation Demand #41

Closed samgdotson closed 4 years ago

samgdotson commented 4 years ago

This issue can be closed when a document or jupyter notebook has been created to answer the following questions (with detailed steps on how to replicate the answers):

Vehicles should be sorted by fuel type (E85, Diesel, Unleaded, Lithium-ion, H2 fuel-cell).

edit1: for clarity

edit 2: updates goal

datw0258 commented 4 years ago

Copied from Slack reply Thanks and last thing just for my clarification: are you looking for TOTAL amount of cars using that fuel type within the fleet, or the amount of models that use that fuel types. For instance, if there were 8 Fords and 3 Dodges using one of the fuel type, are you looking for 11 vehicles or 2 vehicle types.

samgdotson commented 4 years ago

I see, 11 vehicles would be the answer I'm looking for. Thanks for checking!

datw0258 commented 4 years ago

Before I go ahead and submit a request to the Office of Campus Emergency Management for access to information on approximate miles driven by each vehicle of the fleet, there was not a separate excel sheet that contained this information, correct? I see the purchase records and the fuel numbers, but I do not see anything about miles traveled.

samgdotson commented 4 years ago

Yes, I believe that is correct. If that data is available it would be exact miles driven per vehicle. I encourage you to pursue this data, but don't get hung up on waiting for a response -- an approximate answer is fine (by using average mpg and total gallons consumed).

datw0258 commented 4 years ago

In that case should I just look up the average mpg for the different vehicles? Because I initially assumed we would get that statistic by using the exact mileage traveled by each vehicle.

Edit: Many of the vehicles used multiple types of fuel over the course of the year so getting an accurate gas mileage would be very difficult.

*Also edited for grammar

katyhuff commented 4 years ago

Hi Folks, @robfairh should be tightly involved in this discussion. I think he has already asked for and received much of this information from Facilities. We should not be repeatedly asking facilities services for the same data for the same project (there are humans behind the request form). @robfairh can you please coordinate with @samgdotson and @datw0258 ?

datw0258 commented 4 years ago

For clarification, do you still want me to look at the things listed in the initial issue, or just finding GGE equivalents for the technologies you listed and their corresponding $/GGE?

samgdotson commented 4 years ago

I'll edit the issue to reflect our earlier conversation. I think @katyhuff is right, we should be concerned with gallon-gasoline-equivalent for now (the phrase "your mileage may vary" applies here in the literal sense..).

datw0258 commented 4 years ago

I am emailing you an update of where I am so you can let me know if I've misinterpreted some of the checkpoints so far. If there is a better/preferred way of sending files to you (ipynb in this case) in the future, please let me know!

samgdotson commented 4 years ago

Excellent, I just took a look at the files and it seems like you're going the right direction. Regarding the sending of files, this is precisely what GitHub is designed to do! Here's the outline for using GitHub:

  1. Fork the repository
  2. Clone repository using git clone git@github.com:datw0258/2020-dotson-optimal-sizing (I recommend setting up ssh keys)
  3. Set up a new working branch with git checkout -b IssueName
  4. Do the work you're currently doing
  5. Regularly commit changes with git add FileName then ``git commit -m "descriptive message"
  6. When you feel like you've checked most of the boxes, make a pull request by comparing across forks. We can discuss the work that you're doing in a pull request.
datw0258 commented 4 years ago

Before I make a pull request, I just wanted to confirm I am doing this right as I am not completely confident with GitHub yet (it says something like "These branches can be automatically merged").

1) I forked the repository and made a new branch "UIUC-Transportation-Demand" 2) Added a folder called "UIUC-Transportation-Demand" containing the notebook and csv's 3) I open a pull request, and submit it

katyhuff commented 4 years ago

Looks good to me. Just don't press "merge" before a review. Minor comments: capital letters are annoying. Try to use lowercase (indeed, ideally snake case) for folder names, branch names, filenames, etc.

On Thu, May 28, 2020 at 12:54 PM datw0258 notifications@github.com wrote:

Before I make a pull request, I just wanted to confirm I am doing this right as I am not completely confident with GitHub yet (it says something like "These branches can be automatically merged").

  1. I forked the repository and made a new branch "UIUC-Transportation-Demand"
  2. Added a folder called "UIUC-Transportation-Demand" containing the notebook and csv's
  3. I open a pull request, and submit it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arfc/2020-dotson-optimal-sizing/issues/41#issuecomment-635502232, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAFK74JIS5IPAWAQHLFRDRT2QORANCNFSM4NKQCSHA .

-- http://katyhuff.github.com

datw0258 commented 4 years ago

Okay sounds good. Do I have to assign someone (Sam) to the Pull Request, or will it automatically add him?

katyhuff commented 4 years ago

It's best to assign someone. It will not automatically add anyone, though it may "suggest" someone.

On Thu, May 28, 2020 at 1:51 PM datw0258 notifications@github.com wrote:

Okay sounds good. Do I have to assign someone (Sam) to the Pull Request, or will it automatically add him?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/arfc/2020-dotson-optimal-sizing/issues/41#issuecomment-635531233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADAFK2PLSM2WOHRQIJOHXLRT2XCNANCNFSM4NKQCSHA .

-- http://katyhuff.github.com

samgdotson commented 4 years ago

closed by #42