arfc / saltproc

Online reprocessing for molten salt reactors
Other
19 stars 16 forks source link

Cleanup `Depcode` class #172

Closed yardasol closed 1 year ago

yardasol commented 2 years ago

Summary of changes

This PR makes several changes and improvements to the Depcode family of classes with the goal of improving code and documentation readability, as well as making future development and use easier by tweaking the program flow.

Specifically, this PR does the following:

The following changes will be made in a PR after this one is merged:

Required for Merging

Associated Developers

Checklist for Reviewers

Reviewers should use this link to get to the Review Checklist before they begin their review.

yardasol commented 1 year ago

The one change I really wanted was for saltproc/abc.py to be renamed to something else.

I will do this in a future PR, otherwise the changes to abc.py will be obscured by the name change.

yardasol commented 1 year ago

@samgdotson bump

yardasol commented 1 year ago

There are still some changes to be addressed. In particular everywhere that forces a posix path. You're losing one of the key benefits of pathlib!

That's weird, I fixed this in this commit. Try looking at it again?