Closed yardasol closed 1 year ago
The one change I really wanted was for
saltproc/abc.py
to be renamed to something else.
I will do this in a future PR, otherwise the changes to abc.py
will be obscured by the name change.
@samgdotson bump
There are still some changes to be addressed. In particular everywhere that forces a posix path. You're losing one of the key benefits of pathlib!
That's weird, I fixed this in this commit. Try looking at it again?
Summary of changes
This PR makes several changes and improvements to the
Depcode
family of classes with the goal of improving code and documentation readability, as well as making future development and use easier by tweaking the program flow.Specifically, this PR does the following:
Makes the following changes to the following methods and attributes:
Remove junk default paths from depcode class parameters
Makes
npop
,active_cycles
,inactive_cycles
Depcode class attributes and removes them from the input schema.Add some default values to the input schema
Depcode
read_depcode_info()
->read_step_metadata()
sim_info
->step_metadata
read_depcode_step_param()
->read_neutronics_parameters()
param
->neutronics_parameters
read_dep_comp()
->read_depleted_materials()
run_depcode()
->run_depletion_step()
write_depcode_input()
->write_runtime_input()
write_mat_file()
->update_depletable_materials()
iter_inputfile
->runtime_inputfile
iter_matfile
->runtime_matfile
SerpentDepcode
read_depcode_info()
->read_step_metadata()
sim_info
->step_metadata
read_depcode_step_param()
->read_neutronics_parameters()
param
->neutronics_parameters
read_dep_comp()
->read_depleted_materials()
run_depcode()
->run_depletion_step()
write_mat_file()
->update_depletable_materials()
create_nuclide_name_map_zam_to_serpent()
->map_nuclide_code_zam_to_serpent()
convert_nuclide_name_serpent_to_zam()
->convert_nuclide_code_to_zam()
get_nuc_name()
->convert_nuclide_code_to_name()
removechange_sim_par()
->apply_neutron_settings()
change_sim_par()
added
get_neutron_settings()
create_iter_matfile()
->create_runtime_matfile()
replace_burnup_parameters()
->set_power_load()
write_depcode_input()
->write_runtime_input()
cleanup
switch_to_next_geometry()
cleanup
insert_path_to_geometry()
iter_inputfile
->runtime_inputfile
iter_matfile
->runtime_matfile
OpenMCDepcode
read_depcode_info()
->read_step_metadata()
sim_info
->step_metadata
read_depcode_step_param()
->read_neutronics_parameters()
param
->neutronics_parameters
read_dep_comp()
->read_depleted_materials()
run_depcode()
->run_depletion_step()
write_mat_file()
->update_depletable_materials()
write_depcode_input()
->write_runtime_input()
iter_inputfile
->runtime_inputfile
iter_matfile
->runtime_matfile
The following changes will be made in a PR after this one is merged:
abc.py
toabstract_depcode.py
(TODO)Types of changes
Required for Merging
[x] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] My change is a source code change
[x] My change is a user-facing change
[ ] My change is exclusively related to the repository (e.g. GitHub actions workflows, PR/issue templates, etc.)
[x] All new and existing tests passed.
Associated Issues and PRs
Issue: closes #162
Associated Developers
Checklist for Reviewers
Reviewers should use this link to get to the Review Checklist before they begin their review.