search

arfc / transition-scenarios

A repository to hold transition scenarios with Cyclus.
Other
3 stars 12 forks source link

Remove get_transactions function #145

Closed abachma2 closed 1 year ago

abachma2 commented 1 year ago

This PR removes the get_transactions function from scripts/transition_metrics.py, and the associated test in scripts/tests/test_transition_metrics.py. This function is no longer used in any part of the analysis. This PR closes Issue #132.

abachma2 commented 1 year ago

After running the tests for this module, I realized that some of the tests for other functions weren't passing because they hadn't been updated since the functions were last updated. That has been remedied as part of this PR.

abachma2 commented 1 year ago

Thanks for the review @yardasol. I think the idea was to initially move the changes made to the add_receiver_prototype in #132 to the get_transactions function. But instead of doing that I decided it was easier to just delete the get_transaction_function as it is easier to just leave the functionality as is.