arfc / transition-scenarios

A repository to hold transition scenarios with Cyclus.
Other
3 stars 12 forks source link

Input to scenario rebrand #155

Closed nsryan2 closed 7 months ago

nsryan2 commented 10 months ago

This PR closes #153, by renaming the top-level input/ folder to scenarios/. It also restructures scenarios/ to include a README with a brief project description from my limited understanding of each project (like a sentence tops), and moves all the EGxx-EGyy/ folders into one project folder.

I want to clarify that part of the reason there are so many files involved in this change is that I also updated any hard-coded file paths that used to include the top-level input/.

This also addresses a comment from @samgdotson in #152 about the naming scheme.

nsryan2 commented 10 months ago

No problem! I think it was worth it. One of these days, I want to get around to real docs for the scripts at least, and this will help out when I get around to that. I'm not sure either which should be merged first. In #152, you get rid of some of need for changes in #155, so maybe #155 should be first?

abachma2 commented 10 months ago

I don't think there are any big conflicts between the changes in this PR and the changes in #152, but I will wait to merge this one until after 152 is merged to minimize some of the chaos, given the number of files changes in this PR.

samgdotson commented 10 months ago

@nsryan2 did you use git mv to change the name of the directory?

nsryan2 commented 10 months ago

@nsryan2 did you use git mv to change the name of the directory?

I did not, should I have? I'm not familiar with that command.

samgdotson commented 10 months ago

What sequence of commands did you use to rename the folder?

nsryan2 commented 10 months ago

What sequence of commands did you use to rename the folder?

I renamed the input folder scenarios and committed the changes for all the tracked files with git add -u and a normal commit statement

abachma2 commented 10 months ago

152 is now merged if you want to merge master into your branch and resolve any conflicts.

abachma2 commented 9 months ago

Bumping this for @nsryan2 to resolve any conflicts from merging #152

abachma2 commented 8 months ago

Bumping this for resolving conflicts.

nsryan2 commented 7 months ago

Closing this to make our lives easier, going to redo it over the new changes