search

argaar / comfortable-environment-card

A card to display the Heat Index and Discomfort Index (aka Thom Index)
MIT License
54 stars 18 forks source link

Small Language Change #12

Closed GlenWi closed 10 months ago

GlenWi commented 10 months ago

Are you able to change "Relatively comfort" to "Relatively comfortable"?

Many thanks.

argaar commented 10 months ago

You should consider the string is the "official" description presented in the original study 'Thom, E.C., "The discomfort index", Weatherwise, 12: p.57-60, 1959' and should represent the "feeling" for a human being and not the state of an environment, so you're in a state of "relatively comfort" and is not the room that is "relatively comfortable"

GlenWi commented 10 months ago

Hi & thanks for responding. Whether the subject is a human being or an environment it does not make sense in the english language. The environment or the individual can both be described as "relatively comfortable", not "relatively comfort". The individual can experience relative comfort (he/she is relatively comfortable), or the environmental conditions support a level of relative comfort.

I did investigate your reference and it looks like Thom's original DI scale simply gives a score <21 as "No discomfort". It doesn't seem to cater for additional categories (although I found a few that do use your terminology). Perhaps the UTCI definitions attached are better?

In any case it's your code so your decision. I just though it could be cleaner and more meaningful.

Table 1 Another Table 1 UTCI
GlenWi commented 10 months ago

Thanks for the recent changes:-) they look good! Maybe need to slightly change "Less than 50% of population the feel uncomfortable" to "Less than 50% of the population feel uncomfortable". Cheers!

argaar commented 10 months ago

It should be that way as in the last commit 🤔

https://github.com/argaar/comfortable-environment-card/blob/81424965cecbaf81cf57e4ca0dd3c6a02fd8c982/src/localize/languages/en.json#L30C30-L30C30

Will check the release asap