argaar / comfortable-environment-card

A card to display the Heat Index and Discomfort Index (aka Thom Index)
MIT License
52 stars 18 forks source link

Improve text color inside the graph #42

Closed igorsantos07 closed 4 months ago

igorsantos07 commented 4 months ago

This definitely isn't readable :see_no_evil:

image

It could use black or white as text color depending on the index value?

igorsantos07 commented 4 months ago

Doing some quick tweaks in DevTools, I would suggest the following:

As a frontend developer for the past decade or so, I would also suggest removal of box-shadows and text-shadows :eyes: I hope you don't feel offended, as this might seem like a matter of personal taste :pray: But shadows are not present in the usual Home Assistant theme, and in all honesty it kinda makes it feel like a dated UI element (think "Web 2.0" buttons). Sometimes, simplicity is better than overdoing, and there are other means to make text readable against different backgrounds.

Bonus: make the index values follow the decimal places option.

Mocks below: image image image

I can also submit a PR with those changes :)

argaar commented 4 months ago

Don't worry I'm not offended at all, I love to share different points of view and receive suggestions

Of course I'll accept a PR, otherwise I can code it by myself but every bit of help is good 👍

artt652 commented 4 months ago

I'd want suggest to hide descriptions as well in case unavailable of entities, currently in this case card shows wrong description. Screenshot_20240511_213908_Home Assistant