search

argenos / nldates-obsidian

Work with dates in natural language in Obsidian
MIT License
497 stars 46 forks source link

Added commands to replace selected text as link, and as time. #16

Closed pyjamads closed 3 years ago

pyjamads commented 3 years ago

Added two new commands:

pyjamads commented 3 years ago

Thanks for making this @argenos ! Hope this helps :)

arnoan commented 3 years ago

Thanks @pyjamads. I tested the new build locally and can confirm everything works as desired. 👍

I.e. 4 separate actions/shortcuts for parsing dates & times. With dates supporting parsing into either Obsidian Links [[date]], Standard Markdown Style Links [alias](date) or Plain text. And times being parsed into plain text for easy interoperability with the Obsidian Day Planner Plugin.

argenos commented 3 years ago

Thank you very much for the PR! I haven't had much time these days to look into this, so I'll take your word for it! One minor thing before I merge, could you add a small section to the readme with the new commands and a few screenshots? And please also add yourself as the contributor!

pyjamads commented 3 years ago

Added the new commands to the README.md, with a small description for each of them. I think the contributors section will automatically be updated when you pull the PR, unless you want me to explicitly add myself in the README.md. :)

argenos commented 3 years ago

@pyjamads thanks! I know there's always the option to look at the commits and insights in GitHub, but if you want to add yourself to the README I wouldn't have a problem with that!

pyjamads commented 3 years ago

Nah, I'm good, thanks. And thanks for making this :)

argenos commented 3 years ago

Just released 0.3.2 with your PR and some other minor changes! Thanks again!

pyjamads commented 3 years ago

Awesome! 👍

pjeby commented 3 years ago

FYI, this literally pastes the word selectedText instead of the actual selected text. ;-)

pyjamads commented 3 years ago

Oh god, must have missed a set of " + + " @argenos hope you can sort that out 🤞

argenos commented 3 years ago

I’ll check as soon as I have a little time!

pyjamads commented 3 years ago

Went in and fixed the "selectedText" to "${selectedText}" in the link string, so it should be fixed with that.

Hotfix in https://github.com/argenos/nldates-obsidian/pull/17