search

argenos / nldates-obsidian

Work with dates in natural language in Obsidian
MIT License
497 stars 46 forks source link

[WIP] Autosuggest should obey week start #41

Closed liamcain closed 2 years ago

liamcain commented 3 years ago

fixes #33

So, this kinda works. But the problem is that it uses the "week start" setting from the Calendar plugin instead from NLDates 😕

argenos commented 3 years ago

I have an unpushed branch with some changes to the parser. We could use the start of the week as defined by moment (and that setting can be tuned by the calendar settings). Would that work better?

neerajprad commented 3 years ago

I bumped into the same issue today which I presume will be solved by this PR (i.e. next xxx doesn't work as expected on Sunday when my week starts on Monday). Are there any hold ups to merging this PR aside from the issue above? I'll be happy to take a look when I have some time (I'm completely new to Obsidian though so it might take me a while to orient myself).

liamcain commented 2 years ago

Closing this PR in favor of #57 (which as a more complete fix for this issue)