search

argenos / nldates-obsidian

Work with dates in natural language in Obsidian
MIT License
490 stars 44 forks source link

Add multilanguage support #58

Open RensOliemans opened 2 years ago

RensOliemans commented 2 years ago

Implements #19

argenos commented 2 years ago

Sorry about that! GitHub freaked out when I deleted my branch earlier today! It should be good now!

RensOliemans commented 2 years ago

OK no problem, I merged develop back into my branch. One issue which I had is that the new Obsidian version (v0.13.0) isn't on npm, that's why you added "obsidian": "git+https://github.com/obsidianmd/obsidian-api.git#5687a75ecfdb78b6a832127cf6f9229e27e196a0", in package.json. Unfortunately, neither npm nor yarn allows that version for specification for me.

yarn:

error Can't add "obsidian": invalid package version undefined.

npm:

npm ERR! Invalid Version:

How did you get this working for you? The only relevant thing changed is setInstructions in EditorSuggest, but I can't seem to install the correct version

argenos commented 2 years ago

Sorry, we switched to yarn on this release! I'll add to the changelog now

RensOliemans commented 2 years ago

@argenos I merged master back into this branch and set it as ready for review, are you willing to review it?