search

argentlabs / argent-contracts-starknet

Argent accounts for Starknet
https://www.argent.xyz
GNU General Public License v3.0
168 stars 64 forks source link

Update to usize and legacymap #104

Closed gaetbout closed 1 year ago

gaetbout commented 1 year ago

After an update from Starkware, they now support usize for felt array access (and it is mandatory). They also dropped the Map type to LegacyMap All files should now compiles (at least at this push https://github.com/starkware-libs/cairo/commit/e9c4c0c7d62a972a95083df637fcfc713fb4c6e7)

gaetbout commented 1 year ago

Should now allow to run tests using the CLI: cargo run --bin cairo-test -- --starknet --path contracts/

gaetbout commented 1 year ago

Update to use Makefile instead of shell files. Declaring event on account (not using them, for some reason they don't work) Updating TOML file to handle use of cargo CLI starknet commands

delaaxe commented 1 year ago

Can we split the build update and the code changes in separate PRs?

On Mon 30 Jan 2023 at 14:23, gaetbout @.***> wrote:

Update to use Makefile instead of shell files. Declaring event on account (not using them, for some reason they don't work) Updating TOML file to handle use of cargo CLI starknet commands

— Reply to this email directly, view it on GitHub https://github.com/argentlabs/argent-contracts-starknet/pull/104#issuecomment-1408625239, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIKSPHUCILD5GS5KALYY2TWU66E5ANCNFSM6AAAAAAUKJZQWY . You are receiving this because your review was requested.Message ID: @.***>