search

argentlabs / argent-contracts-starknet

Argent accounts for Starknet
https://www.argent.xyz
GNU General Public License v3.0
168 stars 64 forks source link

Test dapp and its tests #111

Closed gaetbout closed 1 year ago

gaetbout commented 1 year ago

Adding the test_dapp contract used for testing other contracts

juniset commented 1 year ago

Do we really need unit tests on the test dapp? The test dapp is used to test calls from the account, but it serves no purpose in itself. Not sure I see value in these tests.

gaetbout commented 1 year ago

Fine for me to remove them, so as you want. I mostly made them check some felt overflow stuff with Cairo 1.0 (plot twist exact same as Cairo 0.x)

juniset commented 1 year ago

I'm fine either way. On one side they're already there so might as well keep them, on the other side it means that we will need to maintain them for no benefit.

Your call.