search

argentlabs / argent-contracts-starknet

Argent accounts for Starknet
https://www.argent.xyz
GNU General Public License v3.0
166 stars 64 forks source link

validate_deploy args: decouple account and proxy #68

Closed sgc-code closed 1 year ago

sgc-code commented 1 year ago

Alternatively to https://github.com/argentlabs/argent-contracts-starknet/pull/67

This should allow to decouple the account from the proxy. Allows to use any proxy with the account (even if we change the proxy constructor down the road)

WARNING i wasn't able to test this yet

juniset commented 1 year ago

I really don't like the idea to add logic to the Proxy, specially in this early phase where we have no guarantee that the __validate_deploy__ will not change in the future. We should keep the proxy as simple as possible.

I much prefer the approach of #69 .

sgc-code commented 1 year ago

specially in this early phase where we have no guarantee that the __validate_deploy__ will not change in the future

Totally agree, i'm closing the PR now that #69 is proven to work