argentlabs / argent-contracts-starknet

Argent accounts for Starknet
https://www.argent.xyz
GNU General Public License v3.0
166 stars 64 forks source link

Account identifier supported by ArgentX accounts #87

Closed bal7hazar closed 1 year ago

bal7hazar commented 1 year ago

It looks like the account identifier supported by ArgentX accounts are currently the old one "0xf10dbd44", it has been updated to "0xa66bd575" (since 0.10 I think or before) in OZ contracts.

Based on this, it makes some OZ contracts (at least ERC-1155) not usable with ArgentX accounts.

A similar issue #85 has been opened and closed about ERC-721. A discussion has also been created on OZ repo.

Not sure if it is already known or not by ArgentX team.

bal7hazar commented 1 year ago

Ok it seems to be supported.

https://github.com/argentlabs/argent-contracts-starknet/blob/develop/contracts/account/library.cairo#L20