argentlabs / argent-x

ArgentX browser extension for StarkNet - made with ❤️ by Argent
https://github.com/argentlabs/argent-x
Other
625 stars 276 forks source link

Bug with 2 submitted transactions and rejecting the first #1654

Closed 0xEniotna closed 1 year ago

0xEniotna commented 1 year ago

Hey, I didnt find a related issue. There seems to be a bug in that situation:

  1. Submit a first tx, do not accept or reject it and close the window (so the waiting-for-acceptance tx will still appear if we open again argentX).
  2. Submit a second transaction (a new argentX popup appears)
  3. Reject the first one

Rejecting the first one seems to somehow automatically accept and trigger the second tx.

dhruvkelawala commented 1 year ago

That's intended. We create a Transaction with a nonce X. When you create another transaction it's created with nonce X+1. If you submit second transaction with nonce X+1, it will fail.